aboutsummaryrefslogtreecommitdiffstats
path: root/src/mesa/drivers/dri/i965/brw_cubemap_normalize.cpp
diff options
context:
space:
mode:
authorKenneth Graunke <[email protected]>2014-04-29 14:29:28 -0700
committerKenneth Graunke <[email protected]>2014-05-01 00:12:22 -0700
commitac30e1adb49ec6947f740b47d90f8403fe416314 (patch)
tree836c04d91a53f5c8526f5c711d88c949a28843f7 /src/mesa/drivers/dri/i965/brw_cubemap_normalize.cpp
parent0380ec467d78f40b5c8134158ca48b4c5378b282 (diff)
i965: Actually emit PIPELINE_SELECT and 3DSTATE_VF_STATISTICS.
For platforms using hardware contexts (currently Gen6+), we failed to emit PIPELINE_SELECT and 3DSTATE_VF_STATISTICS, instead emitting MI_NOOP for both. During one of the context initialization reordering patches, we accidentally moved brw_init_state before we set brw->CMD_PIPELINE_SELECT and brw->CMD_VF_STATISTICS. So, when brw_init_state uploaded initial GPU state (brw_init_state -> brw_upload_initial_gpu_state -> brw_upload_invariant_state), these would be 0 (MI_NOOP). Storing the commands in the context is not worthwhile. We have many generation checks in our state upload code, and for platforms with hardware contexts, this only gets called once per GL context anyway. The cost is negligable, and it's easy to botch context creation ordering. This may fix hangs on Gen6+ when using the media pipeline. Cc: "10.0 10.1" <[email protected]> Signed-off-by: Kenneth Graunke <[email protected]> Reviewed-by: Eric Anholt <[email protected]> Reviewed-by: Ben Widawsky <[email protected]>
Diffstat (limited to 'src/mesa/drivers/dri/i965/brw_cubemap_normalize.cpp')
0 files changed, 0 insertions, 0 deletions