diff options
| author | Brian Behlendorf <[email protected]> | 2009-10-30 13:58:51 -0700 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2009-10-30 13:58:51 -0700 |
| commit | 055ffd98cf80bfc72c28d730753c7d139b704d44 (patch) | |
| tree | 24b7bd860c9d33327652698cd9f9b04dda50e341 /spl_config.h.in | |
| parent | 302b88e6abc3efe86411f9622b0a27a5b8b1f417 (diff) | |
Autoconf --enable-debug-* cleanup
Cleanup the --enable-debug-* configure options, this has been pending
for quite some time and I am glad I finally got to it. To summerize:
1) All SPL_AC_DEBUG_* macros were updated to be a more autoconf
friendly. This mainly involved shift to the GNU approved usage of
AC_ARG_ENABLE and ensuring AS_IF is used rather than directly using
an if [ test ] construct.
2) --enable-debug-kmem=yes by default. This simply enabled keeping
a running tally of total memory allocated and freed and reporting a
memory leak if there was one at module unload. Additionally, it
ensure /proc/spl/kmem/slab will exist by default which is handy.
The overhead is low for this and it should not impact performance.
3) --enable-debug-kmem-tracking=no by default. This option was added
to provide a configure option to enable to detailed memory allocation
tracking. This support was always there but you had to know where to
turn it on. By default this support is disabled because it is known
to badly hurt performence, however it is invaluable when chasing a
memory leak.
4) --enable-debug-kstat removed. After further reflection I can't see
why you would ever really want to turn this support off. It is now
always on which had the nice side effect of simplifying the proc handling
code in spl-proc.c. We can now always assume the top level directory
will be there.
5) --enable-debug-callb removed. This never really did anything, it was
put in provisionally because it might have been needed. It turns out
it was not so I am just removing it to prevent confusion.
Diffstat (limited to 'spl_config.h.in')
| -rw-r--r-- | spl_config.h.in | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/spl_config.h.in b/spl_config.h.in index 409ee372d..06e5766f1 100644 --- a/spl_config.h.in +++ b/spl_config.h.in @@ -3,14 +3,11 @@ /* Atomic types use spinlocks */ #undef ATOMIC_SPINLOCK -/* Define to 1 to enable callb debugging */ -#undef DEBUG_CALLB - -/* Define to 1 to enable kmem debugging */ +/* Define to 1 to enable basic kmem accounting */ #undef DEBUG_KMEM -/* Define to 1 to enable kstat debugging */ -#undef DEBUG_KSTAT +/* Define to 1 to enable detailed kmem tracking */ +#undef DEBUG_KMEM_TRACKING /* register_sysctl_table() wants 2 args */ #undef HAVE_2ARGS_REGISTER_SYSCTL |