diff options
| author | Richard Yao <[email protected]> | 2023-03-11 13:17:59 -0500 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2023-03-14 15:25:01 -0700 |
| commit | 47b994049fd105f54a887e19ec0669e9084b7cf2 (patch) | |
| tree | d26358ffe667541f0e336bb5b7c26f79dfb0a6c4 /module | |
| parent | 3cb293a6f803fe9ef58a6b6d23d50ca5b688da97 (diff) | |
Silence clang static analyzer warnings about stored stack addresses
Clang's static analyzer complains that nvs_xdr() and nvs_native()
functions return pointers to stack memory. That is technically true, but
the pointers are stored in stack memory from the caller's stack frame,
are not read by the caller and are deallocated when the caller returns,
so this is harmless. We set the pointers to NULL to silence the
warnings.
Reviewed-by: Tino Reichardt <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes #14612
Diffstat (limited to 'module')
| -rw-r--r-- | module/nvpair/nvpair.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/module/nvpair/nvpair.c b/module/nvpair/nvpair.c index c8161f116..c494056c5 100644 --- a/module/nvpair/nvpair.c +++ b/module/nvpair/nvpair.c @@ -2808,7 +2808,7 @@ nvs_native_create(nvstream_t *nvs, nvs_native_t *native, char *buf, static void nvs_native_destroy(nvstream_t *nvs) { - (void) nvs; + nvs->nvs_private = NULL; } static int @@ -3189,7 +3189,7 @@ nvs_xdr_destroy(nvstream_t *nvs) switch (nvs->nvs_op) { case NVS_OP_ENCODE: case NVS_OP_DECODE: - xdr_destroy((XDR *)nvs->nvs_private); + nvs->nvs_private = NULL; break; default: break; |