aboutsummaryrefslogtreecommitdiffstats
path: root/module/zfs
diff options
context:
space:
mode:
authorPaul Zuchowski <[email protected]>2019-12-10 18:51:58 -0500
committerBrian Behlendorf <[email protected]>2019-12-10 15:51:58 -0800
commitf0bf4351767ab95b1b5e9baa5445db20ffacd00d (patch)
treeb828b618046572e894277fa706b80508647026f5 /module/zfs
parentb119e2c6f185008001667a621521417111b21aa8 (diff)
zio_decompress_data always ASSERTs successful decompression
This interferes with zdb_read_block trying all the decompression algorithms when the 'd' flag is specified, as some are expected to fail. Also control the output when guessing algorithms, try the more common compression types first, allow specifying lsize/psize, and fix an uninitialized variable. Reviewed-by: Ryan Moeller <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Paul Zuchowski <[email protected]> Closes #9612 Closes #9630
Diffstat (limited to 'module/zfs')
-rw-r--r--module/zfs/zio_compress.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/module/zfs/zio_compress.c b/module/zfs/zio_compress.c
index cdaade27c..01c51347f 100644
--- a/module/zfs/zio_compress.c
+++ b/module/zfs/zio_compress.c
@@ -159,7 +159,6 @@ zio_decompress_data(enum zio_compress c, abd_t *src, void *dst,
* the checksum. However, for extra protection (e.g. against bitflips
* in non-ECC RAM), we handle this error (and test it).
*/
- ASSERT0(ret);
if (zio_decompress_fail_fraction != 0 &&
spa_get_random(zio_decompress_fail_fraction) == 0)
ret = SET_ERROR(EINVAL);