diff options
| author | Rich Ercolani <[email protected]> | 2023-03-24 13:29:19 -0400 |
|---|---|---|
| committer | GitHub <[email protected]> | 2023-03-24 10:29:19 -0700 |
| commit | 0ad5f4344238b548e2240a405d418f7af9290623 (patch) | |
| tree | 17dd3ad03ca6edbcb56ac581661706476f6cc836 /module/zcommon/zfs_fletcher_intel.c | |
| parent | 460d887c439079422b642da87a77dbb896f5e64a (diff) | |
Drop lying to the compiler in the fletcher4 code
This is probably the uncontroversial part of #13631, which fixes
a real problem people are having.
There's still things to improve in our code after this is merged,
but it should stop the breakage that people have reported, where
we lie about a type always being aligned and then pass in stack
objects with no alignment requirement and hope for the best.
Of course, our SIMD code was written with unaligned accesses, so it
doesn't care if we drop this...but some auto-vectorized code that
gcc emits sure does, since we told it it can assume they're aligned.
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Tino Reichardt <[email protected]>
Reviewed-by: Richard Yao <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes #14649
Diffstat (limited to 'module/zcommon/zfs_fletcher_intel.c')
| -rw-r--r-- | module/zcommon/zfs_fletcher_intel.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/module/zcommon/zfs_fletcher_intel.c b/module/zcommon/zfs_fletcher_intel.c index 6108bda7a..34590a155 100644 --- a/module/zcommon/zfs_fletcher_intel.c +++ b/module/zcommon/zfs_fletcher_intel.c @@ -47,14 +47,12 @@ #include <sys/simd.h> #include <zfs_fletcher.h> -ZFS_NO_SANITIZE_UNDEFINED static void fletcher_4_avx2_init(fletcher_4_ctx_t *ctx) { memset(ctx->avx, 0, 4 * sizeof (zfs_fletcher_avx_t)); } -ZFS_NO_SANITIZE_UNDEFINED static void fletcher_4_avx2_fini(fletcher_4_ctx_t *ctx, zio_cksum_t *zcp) { |