diff options
author | Rob N <[email protected]> | 2023-08-26 03:31:29 +1000 |
---|---|---|
committer | GitHub <[email protected]> | 2023-08-25 10:31:29 -0700 |
commit | 804414aad224b432590afe3f9ec114ffb49e0f13 (patch) | |
tree | e5b1382c1a5a9e96b488b0c38a3d23bc3b974e72 /contrib/debian | |
parent | ed39d668ea63e0bbf4e3e4d761a84c7d42ef8f8b (diff) |
tests/block_cloning: rename and document get_same_blocks helper
`get_same_blocks` is a helper to compare two files and return a list of
the blocks that are clones of each other. Its very necessary for block
cloning tests.
Previously it was incorrectly called `unique_blocks`, which is the
_inverse_ of what it does (an early version did list unique blocks; it
was changed but the name was not). So if nothing else, it should be
called `duplicate_blocks`.
But, keeping the details of a clone operation in your head is actually
quite difficult, without the additional overhead of wondering how the
tools work. So I've renamed it to better describe what it does, added a
usage note, and changed it to return block indexes from 0 instead of 1,
to match how L0 blocks are normally counted.
Reviewed-by: Umer Saleem <[email protected]>
Reviewed-by: Kay Pedersen <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes #15181
Diffstat (limited to 'contrib/debian')
0 files changed, 0 insertions, 0 deletions