diff options
| author | Brian Behlendorf <[email protected]> | 2022-12-21 09:17:00 -0800 |
|---|---|---|
| committer | GitHub <[email protected]> | 2022-12-21 09:17:00 -0800 |
| commit | b4cd4fe1aa8c43a779a3bc2132f3772565dc4d07 (patch) | |
| tree | c0264446f8c58aa5ae990cdfde7f0e23f9f49e1c /cmd | |
| parent | bd9dc5a1dcc1d2ec88477af3f6f0bc8c9bdef286 (diff) | |
Revert "zdb: zdb_ddt_leak_init() reads uninitialized memory..."
This reverts commit d30db519af44b905fc52b8c8ba34f6378aa03470. With
this change applied zloop.sh fails reliably with the following ASSERT.
zio_wait(zio_claim(NULL, zcb->zcb_spa, refcnt ? 0 : spa_min_claim_txg(
zcb->zcb_spa), bp, NULL, NULL, ZIO_FLAG_CANFAIL)) == 0 (0x2 == 0x0)
ASSERT at cmd/zdb/zdb.c:5452:zdb_count_block()
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Richard Yao <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #14306
Diffstat (limited to 'cmd')
| -rw-r--r-- | cmd/zdb/zdb.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/cmd/zdb/zdb.c b/cmd/zdb/zdb.c index a3131ab04..b04b220c7 100644 --- a/cmd/zdb/zdb.c +++ b/cmd/zdb/zdb.c @@ -5779,10 +5779,9 @@ zdb_ddt_leak_init(spa_t *spa, zdb_cb_t *zcb) ASSERT(ddt_phys_total_refcnt(&dde) > 1); - if (ddp->ddp_phys_birth == 0) - continue; - for (p = 0; p < DDT_PHYS_TYPES; p++, ddp++) { + if (ddp->ddp_phys_birth == 0) + continue; ddt_bp_create(ddb.ddb_checksum, &dde.dde_key, ddp, &blk); if (p == DDT_PHYS_DITTO) { |