aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Berlin <[email protected]>2024-07-12 20:44:10 -0400
committerTony Hutter <[email protected]>2024-07-16 16:34:07 -0700
commitdfdac38afb1f25de0b35c4b522a839fe78052aed (patch)
tree49fe073750a21c5ba3aa4a66baeace8ec95d17b1
parent08da05400556a778105156640a6f0dbee81e32ee (diff)
Fix missing semicolon in trace_dbuf.h (#16281)
On fedora 40, on the 6.9.4 kernel (in updates-testing), assign_str expands to a "do {<stuff> } while(0)" loop. Without this semicolon, the while(0) is unterminated, causing a cascade of useless errors. With this semicolon, it compiles fine. It also compiles fine on 6.8.11 (the previous kernel). I have not tested earlier kernels than that, but at worst it should add a pointless semicolon. All other instances in the source tree are already terminated with semicolons. Signed-off-by: Daniel Berlin <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Reviewed-by: Tony Hutter <[email protected]>
-rw-r--r--include/os/linux/zfs/sys/trace_dbuf.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/os/linux/zfs/sys/trace_dbuf.h b/include/os/linux/zfs/sys/trace_dbuf.h
index 0f6a98b47..0e9cbdd72 100644
--- a/include/os/linux/zfs/sys/trace_dbuf.h
+++ b/include/os/linux/zfs/sys/trace_dbuf.h
@@ -80,7 +80,7 @@
snprintf(__get_str(msg), TRACE_DBUF_MSG_MAX, \
DBUF_TP_PRINTK_FMT, DBUF_TP_PRINTK_ARGS); \
} else { \
- __assign_str(os_spa, "NULL") \
+ __assign_str(os_spa, "NULL"); \
__entry->ds_object = 0; \
__entry->db_object = 0; \
__entry->db_level = 0; \