aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorKenneth Graunke <[email protected]>2017-06-30 14:00:01 -0700
committerKenneth Graunke <[email protected]>2017-06-30 15:54:44 -0700
commit58d81d9dc21b8fe719959d97890eb4fb2e390840 (patch)
tree8e56739d395e60566928f89eba0320f8dba360d8 /src
parent87d3349393336d25f28ab0ad0cc5b479340e7fa3 (diff)
i965: Add a comment about not needing VALGRIND_MALLOCLIKE_BLOCK.
At first glance this seems missing, since we handle it manually for CPU and WC maps. Although a bit inconsistent, it's actually not necessary. Thanks to Chris Wilson for explaining this to me. Reviewed-by: Matt Turner <[email protected]>
Diffstat (limited to 'src')
-rw-r--r--src/mesa/drivers/dri/i965/brw_bufmgr.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c
index 6cb91f9a23a..abd0722ba6e 100644
--- a/src/mesa/drivers/dri/i965/brw_bufmgr.c
+++ b/src/mesa/drivers/dri/i965/brw_bufmgr.c
@@ -736,7 +736,9 @@ brw_bo_map_gtt(struct brw_context *brw, struct brw_bo *bo, unsigned flags)
return NULL;
}
- /* and mmap it */
+ /* and mmap it. We don't need to use VALGRIND_MALLOCLIKE_BLOCK
+ * because Valgrind will already intercept this mmap call.
+ */
bo->map_gtt = drm_mmap(0, bo->size, PROT_READ | PROT_WRITE,
MAP_SHARED, bufmgr->fd, mmap_arg.offset);
if (bo->map_gtt == MAP_FAILED) {