diff options
| author | Lin Johnson <[email protected]> | 2018-03-26 22:13:32 +0800 |
|---|---|---|
| committer | Tapani Pälli <[email protected]> | 2018-03-27 09:04:52 +0300 |
| commit | 41cf30b8bc55fdf36adac3311002dc32b6715949 (patch) | |
| tree | c38d634f758df7a3349f4372f74aced3396c459f /src | |
| parent | 0024b77e876017b559b76d816d40a2abbd9a0ea1 (diff) | |
mesa: add GL_HALF_FLOAT as supported type to readpixels
EXT_color_buffer_float spec states:
"An INVALID_OPERATION error is generated ... if the color buffer is
a floating-point format and type is not FLOAT, HALF FLOAT, or
UNSIGNED_INT_10F_11F_11F_REV."
This means that GL_HALF_FLOAT type should be supported when color
buffer has floating-point format.
Fixes Android CTS test android.view.cts.PixelCopyTest.
v2: remove comments of EXT_color_buffer_half_float as
EXT_color_buffer_float can use type GL_HALF_FLOAT
Signed-off-by: Lin Johnson <[email protected]>
Reviewed-by: Tapani Pälli <[email protected]>
Diffstat (limited to 'src')
| -rw-r--r-- | src/mesa/main/readpix.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index 6ce340ddf9b..4407f13289e 100644 --- a/src/mesa/main/readpix.c +++ b/src/mesa/main/readpix.c @@ -920,6 +920,8 @@ read_pixels_es3_error_check(GLenum format, GLenum type, case GL_RGBA: if (type == GL_FLOAT && data_type == GL_FLOAT) return GL_NO_ERROR; /* EXT_color_buffer_float */ + if (type == GL_HALF_FLOAT && data_type == GL_FLOAT) + return GL_NO_ERROR; if (type == GL_UNSIGNED_BYTE && data_type == GL_UNSIGNED_NORMALIZED) return GL_NO_ERROR; if (internalFormat == GL_RGB10_A2 && |