aboutsummaryrefslogtreecommitdiffstats
path: root/src/mesa/state_tracker
diff options
context:
space:
mode:
authorMathias Fröhlich <[email protected]>2018-11-01 19:03:26 +0100
committerMathias Fröhlich <[email protected]>2018-11-26 07:57:10 +0100
commita00a8fb8d19e274c454c69cc0c88cec05d4d6e9a (patch)
tree84c7ca0993fa121aef1c923d29c03efb01e58496 /src/mesa/state_tracker
parent6705188cc5234de633839e73dfcfc9016d29f32a (diff)
mesa/st: Avoid extra references in the feedback draw function scope.
The change removes the reference that is held on the entries of the vbuffers[] array. The new code does not do that anymore as following the code into draw_set_vertex_buffers() the draw context holds an other reference as long as it is reset down the function again. So it should be already by that argument save to remove that additional reference count. Reviewed-by: Marek Olšák <[email protected]> Signed-off-by: Mathias Fröhlich <[email protected]>
Diffstat (limited to 'src/mesa/state_tracker')
-rw-r--r--src/mesa/state_tracker/st_draw_feedback.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/mesa/state_tracker/st_draw_feedback.c b/src/mesa/state_tracker/st_draw_feedback.c
index 11097b4cac6..82f2feb86e3 100644
--- a/src/mesa/state_tracker/st_draw_feedback.c
+++ b/src/mesa/state_tracker/st_draw_feedback.c
@@ -185,7 +185,7 @@ st_feedback_draw_vbo(struct gl_context *ctx,
vbuffers[attr].buffer.resource = NULL;
vbuffers[attr].is_user_buffer = false;
- pipe_resource_reference(&vbuffers[attr].buffer.resource, stobj->buffer);
+ vbuffers[attr].buffer.resource = stobj->buffer;
vbuffers[attr].buffer_offset = _mesa_draw_binding_offset(binding);
velements[attr].src_offset =
_mesa_draw_attributes_relative_offset(attrib);
@@ -275,7 +275,6 @@ st_feedback_draw_vbo(struct gl_context *ctx,
if (vb_transfer[attr])
pipe_buffer_unmap(pipe, vb_transfer[attr]);
draw_set_mapped_vertex_buffer(draw, attr, NULL, 0);
- pipe_vertex_buffer_unreference(&vbuffers[attr]);
}
draw_set_vertex_buffers(draw, 0, vp->num_inputs, NULL);
}