aboutsummaryrefslogtreecommitdiffstats
path: root/src/mesa/drivers/dri
diff options
context:
space:
mode:
authorIan Romanick <[email protected]>2016-10-23 23:47:14 -0700
committerIan Romanick <[email protected]>2017-01-20 15:41:23 -0800
commitc95380c4044237d73fb537511667c3c8f658fcee (patch)
tree2776cf7af320c7b3383e66706ec095cd1e20bd50 /src/mesa/drivers/dri
parent30164d501dd9d9e8d13ada1f030b36f7306bf7a7 (diff)
i965: Really don't emit Q or UQ moves on Gen < 8
It's much easier to do this in the generator rather than while coming out of NIR. brw_type_for_nir_type doesn't know the Gen, so we'd have to add a bunch of plumbing. The alternate fix is to not emit int64 moves for doubles in the first place... but that seems even more difficult. This change won't catch non-MOV instructions that try to use 64-bit integer types on Gen < 8. This may convert certain kinds of bugs in to different kinds of bugs that are more difficult to detect (since the assertions in the function won't catch them). NOTE: I don't think anything can emit mixed-type 64-bit moves until the same platform supports both ARB_gpu_shader_fp64 and ARB_gpu_shader_int64. When we enable int64 on Gen < 8, we can solve this problem other ways. This prevents regressions on HSW in the next patch. Signed-off-by: Ian Romanick <[email protected]> Reviewed-by: Matt Turner <[email protected]>
Diffstat (limited to 'src/mesa/drivers/dri')
-rw-r--r--src/mesa/drivers/dri/i965/brw_eu_emit.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c
index cd17e3b0b0b..8d08d1856ab 100644
--- a/src/mesa/drivers/dri/i965/brw_eu_emit.c
+++ b/src/mesa/drivers/dri/i965/brw_eu_emit.c
@@ -94,6 +94,14 @@ unsigned
brw_reg_type_to_hw_type(const struct gen_device_info *devinfo,
enum brw_reg_type type, enum brw_reg_file file)
{
+ /* If the type is Q or UQ and Gen < 8, change the type to DF. On Gen < 8,
+ * the only Q or UQ moves the should occur are actually to move doubles
+ * anyway.
+ */
+ if (devinfo->gen < 8 && (type == BRW_REGISTER_TYPE_UQ ||
+ type == BRW_REGISTER_TYPE_Q))
+ type = BRW_REGISTER_TYPE_DF;
+
if (file == BRW_IMMEDIATE_VALUE) {
static const int imm_hw_types[] = {
[BRW_REGISTER_TYPE_UD] = BRW_HW_REG_TYPE_UD,