diff options
| author | Leo Liu <[email protected]> | 2016-07-14 09:19:59 -0400 |
|---|---|---|
| committer | Leo Liu <[email protected]> | 2016-07-18 09:20:40 -0400 |
| commit | 134d6e4e4f980d738361bfcae1daedb8cc58b5df (patch) | |
| tree | 42111b499933a57bf610b9cef5e58a32fe6c51c0 /src/gallium | |
| parent | 0f2516d88f6607b2816445c2dc18607cdaf1beff (diff) | |
vl/dri3: fix a memory leak from front buffer
Inspired by fix for mem leak of vdpau interop, resource_from_handle
set texture reference count, that need to be decreased and released,
recall there is a similar case for DRI3, that is with VA-API glx
extension, there is temporary TFP(texture from pixmap), we target it
through dma-buf. leak happens when without count down the reference.
Checked and found with mpv vo=opengl case, there only one static TFP,
the leak happens once, but for totem player using gstreamer VA-API glx,
the dynamic TFP for each frame, so leak quite a bit.
This fixes mem leak for mpv and totem.
Signed-off-by: Leo Liu <[email protected]>
Cc: "12.0" <[email protected]>
Diffstat (limited to 'src/gallium')
| -rw-r--r-- | src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3.c index f7f572ea5c2..493e64574a6 100644 --- a/src/gallium/auxiliary/vl/vl_winsys_dri3.c +++ b/src/gallium/auxiliary/vl/vl_winsys_dri3.c @@ -89,6 +89,7 @@ dri3_free_front_buffer(struct vl_dri3_screen *scrn, { xcb_sync_destroy_fence(scrn->conn, buffer->sync_fence); xshmfence_unmap_shm(buffer->shm_fence); + pipe_resource_reference(&buffer->texture, NULL); FREE(buffer); } |