diff options
| author | Gurchetan Singh <[email protected]> | 2019-04-15 20:36:54 -0700 |
|---|---|---|
| committer | Gurchetan Singh <[email protected]> | 2019-04-18 15:38:04 -0700 |
| commit | 599d55371c83e2a535814c78b62f4293be79408d (patch) | |
| tree | 8195d33c840bce00b157dbdf216642ca7c4baf67 /src/gallium/drivers/virgl/virgl_buffer.c | |
| parent | dfd79079daf08cba0e1d5defc18dedeffb0c6327 (diff) | |
virgl: wait after a flush
We really need to wait under certain circumstances, or we can end
up writing to memory the same time the host is reading.
Partial revert of d6dc68 ("virgl: use uint16_t mask instead of separate booleans").
Test cases:
- dEQP-GLES31.functional.texture.texture_buffer.render_modify.as_vertex_array.bufferdata
on vtest protocol version 2
- Flickering during Alien Isolation
Fixes: d6dc68 ("virgl: use uint16_t mask instead of separate booleans")
Signed-off-by: Gurchetan Singh <[email protected]>
Reviewed-By: Gert Wollny <[email protected]>
Reviewed-By: Piotr Rak <[email protected]>
Diffstat (limited to 'src/gallium/drivers/virgl/virgl_buffer.c')
| -rw-r--r-- | src/gallium/drivers/virgl/virgl_buffer.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/gallium/drivers/virgl/virgl_buffer.c b/src/gallium/drivers/virgl/virgl_buffer.c index 7081c090814..fd00b1748c4 100644 --- a/src/gallium/drivers/virgl/virgl_buffer.c +++ b/src/gallium/drivers/virgl/virgl_buffer.c @@ -53,12 +53,12 @@ static void *virgl_buffer_transfer_map(struct pipe_context *ctx, ctx->flush(ctx, NULL, 0); readback = virgl_res_needs_readback(vctx, vbuf, usage, 0); - if (readback) { + if (readback) vs->vws->transfer_get(vs->vws, vbuf->hw_res, box, trans->base.stride, trans->l_stride, trans->offset, level); + if (readback || flush) vs->vws->resource_wait(vs->vws, vbuf->hw_res); - } ptr = vs->vws->resource_map(vs->vws, vbuf->hw_res); if (!ptr) { |