diff options
author | Nicolai Hähnle <[email protected]> | 2017-04-12 11:01:19 +0200 |
---|---|---|
committer | Nicolai Hähnle <[email protected]> | 2017-04-13 17:31:11 +0200 |
commit | 4f7e3fbb50f06ab523594a7ee4693b1a95c0e66a (patch) | |
tree | 0bc81842e95535939c26a3d8f45c6f99177aba15 /src/gallium/drivers/radeonsi/si_state_draw.c | |
parent | 472c84d1ad0ae9d3e7dbe469ae04e2efe65143fa (diff) |
radeonsi: fix gl_BaseVertex in non-indexed draws
gl_BaseVertex is supposed to be 0 in non-indexed draws. Unfortunately, the
way they're implemented, the VGT always generates indices starting at 0,
and the VS prolog adds the start index.
There's a VGT_INDX_OFFSET register which causes the VGT to start at a
driver-defined index. However, this register cannot be written from
indirect draws.
So fix this unlikely case by setting a bit to tell the VS whether the
draw is indexed or not, so that gl_BaseVertex can be adjusted accordingly
when used.
Fixes a bug in
KHR-GL45.shader_draw_parameters_tests.ShaderMultiDrawArraysParameters.*
Reviewed-by: Marek Olšák <[email protected]>
Diffstat (limited to 'src/gallium/drivers/radeonsi/si_state_draw.c')
-rw-r--r-- | src/gallium/drivers/radeonsi/si_state_draw.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index 0d70ea9d6d7..aa528ce4393 100644 --- a/src/gallium/drivers/radeonsi/si_state_draw.c +++ b/src/gallium/drivers/radeonsi/si_state_draw.c @@ -494,8 +494,12 @@ static void si_emit_rasterizer_prim_state(struct si_context *sctx) sctx->last_sc_line_stipple = rs->pa_sc_line_stipple; } -static void si_emit_vs_state(struct si_context *sctx) +static void si_emit_vs_state(struct si_context *sctx, + const struct pipe_draw_info *info) { + sctx->current_vs_state &= C_VS_STATE_INDEXED; + sctx->current_vs_state |= S_VS_STATE_INDEXED(!!info->indexed); + if (sctx->current_vs_state != sctx->last_vs_state) { struct radeon_winsys_cs *cs = sctx->b.gfx.cs; @@ -1305,7 +1309,7 @@ void si_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *info) si_emit_rasterizer_prim_state(sctx); if (sctx->tes_shader.cso) si_emit_derived_tess_state(sctx, info, &num_patches); - si_emit_vs_state(sctx); + si_emit_vs_state(sctx, info); si_emit_draw_registers(sctx, info, num_patches); si_ce_pre_draw_synchronization(sctx); |