diff options
author | Eric Anholt <[email protected]> | 2020-04-21 13:26:14 -0700 |
---|---|---|
committer | Marge Bot <[email protected]> | 2020-05-01 16:26:32 +0000 |
commit | b420d04e1f744d15622f89180d1e3e511d92a8ba (patch) | |
tree | 2ff5b39b59a49567d8ea8a770e8ddff39cadb4a9 /src/gallium/drivers/freedreno/ir3/ir3_gallium.c | |
parent | 73f34e0d4677aaa705e49ba5bcf498d5e6d673d8 (diff) |
freedreno/ir3: Fix register allocation assertion failures.
We were failing to tell the allocator about the restriction that scalar
texture instructions (allocated as scalar regs) couldn't be allocated such
that the start of the full unwritemasked vector started before r0. There
was a patch in select_reg_callback on a6xx that tried to work around that,
but you could still end up backed into a corner you shouldn't be because
we didn't tell the RA what it needed.
Fixes compiler assertion failures on a300-a400's blit_z shader, used for
Z32F gmem blits.
Looks like as a result we get tighter register allocation but more nops:
instructions in affected programs: 757945 -> 760356 (0.32%)
nops in affected programs: 317983 -> 320468 (0.78%)
non-nops in affected programs: 27525 -> 27451 (-0.27%)
mov in affected programs: 3098 -> 3023 (-2.42%)
dwords in affected programs: 109664 -> 110656 (0.90%)
last-baryf in affected programs: 112701 -> 112847 (0.13%)
full in affected programs: 4326 -> 4011 (-7.28%)
sstall in affected programs: 120550 -> 120836 (0.24%)
(ss) in affected programs: 13939 -> 13918 (-0.15%)
(sy) in affected programs: 3006 -> 2786 (-7.32%)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4562>
Diffstat (limited to 'src/gallium/drivers/freedreno/ir3/ir3_gallium.c')
0 files changed, 0 insertions, 0 deletions