diff options
| author | Christopher Egert <[email protected]> | 2020-05-15 16:41:15 +0200 |
|---|---|---|
| committer | Bas Nieuwenhuizen <[email protected]> | 2020-05-17 01:12:59 +0200 |
| commit | 78615dcca19699737bf9cbc784b66d9ea966bcc0 (patch) | |
| tree | 817ce9cf275a904788cb70d0241e85982f43f4ac /src/amd/vulkan/radv_formats.c | |
| parent | 632a921bd0dd40ad3167a0b8a74fe7054a78256a (diff) | |
radv: use util_float_to_half_rtz
Since commit 8b8af6d398a94cb07015c695fdfdb5c157aa72cf there is a
performance regression in dirt 4 on picasso APUs.
The game ends up feeding a large value into this which overflows on the
conversion to 16bit float. With the old implementation (which now lives
in util_float_to_half_rtz) it would be clamped to inf-1, while the new
one returns inf. This causes a performance hit somehow at some point
down the line.
Reviewed-by: Bas Nieuwenhuizen <[email protected]>
Fixes: 8b8af6d398a "gallium/util: Switch util_float_to_half to _mesa_float_to_half()'s impl."
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5062>
Diffstat (limited to 'src/amd/vulkan/radv_formats.c')
| -rw-r--r-- | src/amd/vulkan/radv_formats.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c index a790459c900..badfcc4f72f 100644 --- a/src/amd/vulkan/radv_formats.c +++ b/src/amd/vulkan/radv_formats.c @@ -1060,7 +1060,7 @@ bool radv_format_pack_clear_color(VkFormat format, if (channel->size == 32) { memcpy(&v, &value->float32[c], 4); } else if(channel->size == 16) { - v = util_float_to_half(value->float32[c]); + v = util_float_to_half_rtz(value->float32[c]); } else { fprintf(stderr, "failed to fast clear for unhandled float size in format %d\n", format); return false; |