aboutsummaryrefslogtreecommitdiffstats
path: root/src/amd/common/ac_gpu_info.h
diff options
context:
space:
mode:
authorEmil Velikov <[email protected]>2019-06-21 17:26:44 +0100
committerEmil Velikov <[email protected]>2019-06-28 17:49:32 +0100
commit4ec32413f3545e771e9f4fee809f3b71fff75a1c (patch)
tree6884ae46a48cea2587af5572917b328be0fa5cab /src/amd/common/ac_gpu_info.h
parent7c745f6148d92bcbf2d27598f00c586cf106ed01 (diff)
ac: change ac_query_gpu_info() signature
Currently libdrm_amdgpu provides a typedef of the various handles. While the goal was to make those opaque, it effectively became part of the API To the best of my knowledge there are two ways to have opaque handles: - "typedef void *foo;" - rather messy IMHO - "stuct foo;" and use "struct foo *" through the API In our case amdgpu_device_handle is used only internally, plus respective code is not used or applicable for r300 and r600. Hence we copied the typedef. Seemingly this will be a problem since libdrm_amdgpu wants to change the API, while not updating the code(?). Either way, we can safely s/amdgpU_device_handle/void */ and carry on. Cc: Michel Dänzer <[email protected]> Signed-off-by: Emil Velikov <[email protected]> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Diffstat (limited to 'src/amd/common/ac_gpu_info.h')
-rw-r--r--src/amd/common/ac_gpu_info.h4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/amd/common/ac_gpu_info.h b/src/amd/common/ac_gpu_info.h
index d296c7eb89f..cea6181dc7e 100644
--- a/src/amd/common/ac_gpu_info.h
+++ b/src/amd/common/ac_gpu_info.h
@@ -35,8 +35,6 @@
extern "C" {
#endif
-/* Prior to C11 the following may trigger a typedef redeclaration warning */
-typedef struct amdgpu_device *amdgpu_device_handle;
struct amdgpu_gpu_info;
struct radeon_info {
@@ -151,7 +149,7 @@ struct radeon_info {
uint32_t cik_macrotile_mode_array[16];
};
-bool ac_query_gpu_info(int fd, amdgpu_device_handle dev,
+bool ac_query_gpu_info(int fd, void *dev_p,
struct radeon_info *info,
struct amdgpu_gpu_info *amdinfo);