aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLucas Stach <[email protected]>2019-09-16 14:43:13 +0200
committerLucas Stach <[email protected]>2019-10-18 10:12:07 +0000
commitf6461df63a9e3e5f215a03a8fb8f2d4d41152007 (patch)
tree14f2a0e49b7ef9ec992b7180cbc619e55c554662
parent5be5b53b6d6e59acb683644cdab533fd80b00713 (diff)
gallium/util: don't depend on implementation defined behavior in listen()
Using 0 as the backlog argument to listen() is exploiting implementation defined behavior and will lead to no connections being accepted on some libc implementations. Quote of the listen manpage: "A backlog argument of 0 may allow the socket to accept connections, in which case the length of the listen queue may be set to an implementation-defined minimum value." Fix this by using a more sensible backlog value. Signed-off-by: Lucas Stach <[email protected]>
-rw-r--r--src/gallium/auxiliary/util/u_network.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gallium/auxiliary/util/u_network.c b/src/gallium/auxiliary/util/u_network.c
index a87ddab0bde..31139f2983f 100644
--- a/src/gallium/auxiliary/util/u_network.c
+++ b/src/gallium/auxiliary/util/u_network.c
@@ -167,7 +167,7 @@ u_socket_listen_on_port(uint16_t portnum)
return -1;
}
- listen(s, 0);
+ listen(s, 1);
return s;
#else