aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRhys Perry <[email protected]>2020-05-07 15:02:20 +0100
committerMarge Bot <[email protected]>2020-05-13 12:26:42 +0000
commit0c7bed72f7948d51a2109f181e7a2d3c77dbd19e (patch)
tree6c9b1169fc2994486191ef03c5daccc0a5520dab
parenta6beb051aff4f11784cb974a1dc3647e74f2389c (diff)
aco: simplify consecutive ordered vmem/lds writes optimization
This was unnecessary and messed with statistics Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Daniel Schürmann <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4949>
-rw-r--r--src/amd/compiler/aco_insert_waitcnt.cpp12
1 files changed, 2 insertions, 10 deletions
diff --git a/src/amd/compiler/aco_insert_waitcnt.cpp b/src/amd/compiler/aco_insert_waitcnt.cpp
index e4087e7add5..4a8596b5af8 100644
--- a/src/amd/compiler/aco_insert_waitcnt.cpp
+++ b/src/amd/compiler/aco_insert_waitcnt.cpp
@@ -402,22 +402,14 @@ wait_imm check_instr(Instruction* instr, wait_ctx& ctx)
continue;
/* Vector Memory reads and writes return in the order they were issued */
- if (instr->isVMEM() && ((it->second.events & vm_events) == event_vmem)) {
- it->second.remove_counter(counter_vm);
- if (!it->second.counters)
- it = ctx.gpr_map.erase(it);
+ if (instr->isVMEM() && ((it->second.events & vm_events) == event_vmem))
continue;
- }
/* LDS reads and writes return in the order they were issued. same for GDS */
if (instr->format == Format::DS) {
bool gds = static_cast<DS_instruction*>(instr)->gds;
- if ((it->second.events & lgkm_events) == (gds ? event_gds : event_lds)) {
- it->second.remove_counter(counter_lgkm);
- if (!it->second.counters)
- it = ctx.gpr_map.erase(it);
+ if ((it->second.events & lgkm_events) == (gds ? event_gds : event_lds))
continue;
- }
}
wait.combine(it->second.imm);