diff options
| author | Timothy Arceri <[email protected]> | 2015-11-13 11:41:52 +1100 |
|---|---|---|
| committer | Timothy Arceri <[email protected]> | 2015-11-18 07:30:19 +1100 |
| commit | 03bbddd139fc3e543cb3aedf64236808ca20eeca (patch) | |
| tree | 923a9ebfdedc7b7a26c1ddb465e79dec7868d9f8 | |
| parent | 4f4ca6b90ac33ad84bc469f58df1682e93ab3733 (diff) | |
glsl: don't validate binding when its not needed
Checking that the flag has been set is all the validation thats
needed here.
Also not calling the binding validation function will make things
much simpler when adding compile time constant support as we
won't need to resolve the binding value.
Reviewed-by: Emil Velikov <[email protected]>
| -rw-r--r-- | src/glsl/ast_to_hir.cpp | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 9856f16323b..97e2351790c 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -6133,8 +6133,11 @@ ast_process_struct_or_iface_block_members(exec_list *instructions, "uniform block"); } - if (qual->flags.q.explicit_binding) - validate_binding_qualifier(state, &loc, decl_type, qual); + if (qual->flags.q.explicit_binding) { + _mesa_glsl_error(&loc, state, + "binding layout qualifier cannot be applied " + "to struct or interface block members"); + } if (qual->flags.q.std140 || qual->flags.q.std430 || |