aboutsummaryrefslogtreecommitdiffstats
path: root/al/effects/null.cpp
diff options
context:
space:
mode:
authorChris Robinson <[email protected]>2022-03-05 01:14:26 -0800
committerChris Robinson <[email protected]>2022-03-05 01:14:26 -0800
commit2dc9cf170c08f0b7f35ec46cb17c829888e7392c (patch)
tree76865c75ba9cd0dce3452988ff28ac7636a82872 /al/effects/null.cpp
parent7bec22abb61fa1b87e157dd6b577ba174d3273d3 (diff)
Simplify committing EAX properties
Based on DirectSound's EAX behavior, committing any EAX property commits *all* deferred property changes, not just the object being changed. So applying EAX changes can be handled in one place.
Diffstat (limited to 'al/effects/null.cpp')
-rw-r--r--al/effects/null.cpp14
1 files changed, 3 insertions, 11 deletions
diff --git a/al/effects/null.cpp b/al/effects/null.cpp
index 5602280b..a0eb2247 100644
--- a/al/effects/null.cpp
+++ b/al/effects/null.cpp
@@ -106,9 +106,7 @@ class EaxNullEffect final :
public:
EaxNullEffect();
- // [[nodiscard]]
- bool dispatch(
- const EaxEaxCall& eax_call) override;
+ void dispatch(const EaxEaxCall& eax_call) override;
// [[nodiscard]]
bool apply_deferred() override;
@@ -133,16 +131,10 @@ EaxNullEffect::EaxNullEffect()
{
}
-// [[nodiscard]]
-bool EaxNullEffect::dispatch(
- const EaxEaxCall& eax_call)
+void EaxNullEffect::dispatch(const EaxEaxCall& eax_call)
{
- if (eax_call.get_property_id() != 0)
- {
+ if(eax_call.get_property_id() != 0)
throw EaxNullEffectException{"Unsupported property id."};
- }
-
- return false;
}
bool EaxNullEffect::apply_deferred()