diff options
author | Adam Domurad <[email protected]> | 2012-05-17 14:14:03 -0400 |
---|---|---|
committer | Adam Domurad <[email protected]> | 2012-05-17 14:14:03 -0400 |
commit | b42384fe344b0af2a54eb00735f7d59b6ba1ab6e (patch) | |
tree | 1dc30db08c963ecdd9fbe5c7186a007f110b8057 /netx/net/sourceforge/jnlp/SecurityDesc.java | |
parent | 0c598ca6848b417c79245a971f26570d05144132 (diff) |
Went through the source of IcedTeaWeb with FindBugs and went over all reported cases of == being used to compare String's. Some usage cases were valid (eg, .equals eventually called, magic String value). I noted one such usage case. The others were changed to .equals calls.
Diffstat (limited to 'netx/net/sourceforge/jnlp/SecurityDesc.java')
-rw-r--r-- | netx/net/sourceforge/jnlp/SecurityDesc.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/netx/net/sourceforge/jnlp/SecurityDesc.java b/netx/net/sourceforge/jnlp/SecurityDesc.java index abb61bd..9455c9a 100644 --- a/netx/net/sourceforge/jnlp/SecurityDesc.java +++ b/netx/net/sourceforge/jnlp/SecurityDesc.java @@ -202,7 +202,7 @@ public class SecurityDesc { PermissionCollection permissions = getSandBoxPermissions(); // discard sandbox, give all - if (type == ALL_PERMISSIONS) { + if (ALL_PERMISSIONS.equals(type)) { permissions = new Permissions(); if (customTrustedPolicy == null) { permissions.add(new AllPermission()); @@ -213,7 +213,7 @@ public class SecurityDesc { } // add j2ee to sandbox if needed - if (type == J2EE_PERMISSIONS) + if (J2EE_PERMISSIONS.equals(type)) for (int i = 0; i < j2eePermissions.length; i++) permissions.add(j2eePermissions[i]); |