diff options
author | Sven Gothel <[email protected]> | 2022-11-28 22:01:56 +0100 |
---|---|---|
committer | Sven Gothel <[email protected]> | 2022-11-28 22:01:56 +0100 |
commit | 542369fe13a535b817a42f890f51e1ca09ba552c (patch) | |
tree | b732befc4c69d8b7882d07725ba4f75861182cac /src/direct_bt/L2CAPComm.cpp | |
parent | 9d863d14db95d3c30f0b41b8ce3ed89275934f1d (diff) |
clang-tidy fixes part-3 / 4, adding Check `performance-*`
See also jaulib commit 9160f9a4b74f5e5ae07f715025ea4d3aafdf6ab3
Details:
- Using 'const T&' as method argument type where applicable, i.e. not when required to pass value off-thread.
- Notable: Can also hold a default value!
- Using `const T&` in range-loop where applicable
- Drop std::move for trivial types
- ...
Diffstat (limited to 'src/direct_bt/L2CAPComm.cpp')
-rw-r--r-- | src/direct_bt/L2CAPComm.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/direct_bt/L2CAPComm.cpp b/src/direct_bt/L2CAPComm.cpp index a0f9d90d..cb76781b 100644 --- a/src/direct_bt/L2CAPComm.cpp +++ b/src/direct_bt/L2CAPComm.cpp @@ -429,7 +429,7 @@ bool L2CAPClient::close_impl() noexcept { int kerr; if( 0 != ( kerr = ::pthread_kill(_tid_read, SIGALRM) ) ) { ERR_PRINT("L2CAPClient::close: pthread_kill read %p FAILED: %d; dev_id %u, dd %d, %s, psm %s, cid %s; %s", - (void*)_tid_read, kerr, + (void*)_tid_read, kerr, // NOLINT(performance-no-int-to-ptr) adev_id, socket_.load(), remoteAddressAndType.toString().c_str(), to_string(psm).c_str(), to_string(cid).c_str(), getStateString().c_str()); @@ -440,7 +440,7 @@ bool L2CAPClient::close_impl() noexcept { int kerr; if( 0 != ( kerr = ::pthread_kill(_tid_connect, SIGALRM) ) ) { ERR_PRINT("L2CAPClient::close: Start: pthread_kill connect %p FAILED: %d; dev_id %u, dd %d, %s, psm %s, cid %s; %s", - (void*)_tid_connect, kerr, + (void*)_tid_connect, kerr, // NOLINT(performance-no-int-to-ptr) adev_id, socket_.load(), remoteAddressAndType.toString().c_str(), to_string(psm).c_str(), to_string(cid).c_str(), getStateString().c_str()); @@ -798,7 +798,7 @@ bool L2CAPServer::close_impl() noexcept { int kerr; if( 0 != ( kerr = ::pthread_kill(_tid_accept, SIGALRM) ) ) { ERR_PRINT("L2CAPServer::close: Start: pthread_kill connect %p FAILED: %d; dev_id %u, dd %d, psm %s, cid %s, local %s", - (void*)_tid_accept, kerr, + (void*)_tid_accept, kerr, // NOLINT(performance-no-int-to-ptr) adev_id, socket_.load(), to_string(psm).c_str(), to_string(cid).c_str(), localAddressAndType.toString().c_str()); } |