Fix various bugs found by Coverity scanner.

Uninitialized variables, missing divide by zero checks, missing
virtual destructor, etc. Only thing serious is bug in TLS maximum
fragment decoder; missing breaks in switch statement meant receiver
would treat any negotiated max frament as 4k limit.

1 files changed, 4 insertions, 0 deletions

diff --git a/src/lib/tls/tls_extensions.cpp b/src/lib/tls/tls_extensions.cpp
index b7ba4a917..5f28c98b8 100644
--- a/src/lib/tls/tls_extensions.cpp
+++ b/src/lib/tls/tls_extensions.cpp
@@ -246,12 +246,16 @@ Maximum_Fragment_Length::Maximum_Fragment_Length(TLS_Data_Reader& reader,
       {
       case 1:
          m_max_fragment = 512;
+         break;
       case 2:
          m_max_fragment = 1024;
+         break;
       case 3:
          m_max_fragment = 2048;
+         break;
       case 4:
          m_max_fragment = 4096;
+         break;
       default:
          throw TLS_Exception(Alert::ILLEGAL_PARAMETER,
                              "Bad value " + std::to_string(val) + " for max fragment len");