diff options
| author | Philippe Lieser <[email protected]> | 2021-09-14 16:41:01 +0200 |
|---|---|---|
| committer | Philippe Lieser <[email protected]> | 2021-09-14 16:41:01 +0200 |
| commit | e84a5f9416947ba4916fb20259bc422b049f0729 (patch) | |
| tree | 1a9b30f7e658239e643c0e8da6b83941c5e8dcae /src/lib/pk_pad | |
| parent | 897e6b00aa3ac56e8fdf02a0a5cf39a2329fd127 (diff) | |
Clarify some docstrings and comments
Diffstat (limited to 'src/lib/pk_pad')
| -rw-r--r-- | src/lib/pk_pad/eme_oaep/oaep.cpp | 4 | ||||
| -rw-r--r-- | src/lib/pk_pad/eme_oaep/oaep.h | 2 | ||||
| -rw-r--r-- | src/lib/pk_pad/mgf1/mgf1.h | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/src/lib/pk_pad/eme_oaep/oaep.cpp b/src/lib/pk_pad/eme_oaep/oaep.cpp index 90d7bbe70..8fb85617a 100644 --- a/src/lib/pk_pad/eme_oaep/oaep.cpp +++ b/src/lib/pk_pad/eme_oaep/oaep.cpp @@ -62,14 +62,14 @@ secure_vector<uint8_t> OAEP::unpad(uint8_t& valid_mask, Also have to be careful about timing attacks! Pointed out by Falko Strenzke. - According to the standard (Section 7.1.1), the encryptor always + According to the standard (RFC 3447 Section 7.1.1), the encryptor always creates a message as follows: i. Concatenate a single octet with hexadecimal value 0x00, maskedSeed, and maskedDB to form an encoded message EM of length k octets as EM = 0x00 || maskedSeed || maskedDB. where k is the length of the modulus N. - Therefore, the first byte can always be skipped safely. + Therefore, the first byte should always be zero. */ const auto leading_0 = CT::Mask<uint8_t>::is_zero(in[0]); diff --git a/src/lib/pk_pad/eme_oaep/oaep.h b/src/lib/pk_pad/eme_oaep/oaep.h index 0b563e35f..de9b399b7 100644 --- a/src/lib/pk_pad/eme_oaep/oaep.h +++ b/src/lib/pk_pad/eme_oaep/oaep.h @@ -15,7 +15,7 @@ namespace Botan { /** * OAEP (called EME1 in IEEE 1363 and in earlier versions of the library) -* as specified in PKCS#1 v2.0 (RFC 2437) +* as specified in PKCS#1 v2.0 (RFC 2437) or PKCS#1 v2.1 (RFC 3447) */ class OAEP final : public EME { diff --git a/src/lib/pk_pad/mgf1/mgf1.h b/src/lib/pk_pad/mgf1/mgf1.h index d0f469402..eb421b142 100644 --- a/src/lib/pk_pad/mgf1/mgf1.h +++ b/src/lib/pk_pad/mgf1/mgf1.h @@ -19,7 +19,7 @@ class HashFunction; * @param hash hash function to use * @param in input buffer * @param in_len size of the input buffer in bytes -* @param out output buffer +* @param out output buffer. The buffer is XORed with the output of MGF1. * @param out_len size of the output buffer in bytes */ void mgf1_mask(HashFunction& hash, |