diff options
| author | Jack Lloyd <[email protected]> | 2016-01-17 19:02:13 -0500 |
|---|---|---|
| committer | Jack Lloyd <[email protected]> | 2016-01-17 19:10:33 -0500 |
| commit | 6fcbd57915d7870c2782bd6e098903353e8756b0 (patch) | |
| tree | c40505fbf8021819dc15d8a632a2d6fb5557f2aa /src/cli | |
| parent | de22a9eda8bfb087b690feb962fae8313ee526d4 (diff) | |
Add missing overrides and fix -Wpedantic 'extra ;' warnings
Remove -Wsuggest-attribute=noreturn from maintainer mode flags as it
seems like outside of the assertion failure macro any other suggestion
would always be a false positive (an unimplemented function or the like).
Or at least, if such a function needing noreturn to assist with static
analysis is added in the future it will be obvious, by virtue of the
static analyzer warnings which occur due to the missing noreturn
preventing the analyzer from understanding code flow.
Diffstat (limited to 'src/cli')
| -rw-r--r-- | src/cli/asn1.cpp | 2 | ||||
| -rw-r--r-- | src/cli/cc_enc.cpp | 2 | ||||
| -rw-r--r-- | src/cli/utils.cpp | 4 |
3 files changed, 4 insertions, 4 deletions
diff --git a/src/cli/asn1.cpp b/src/cli/asn1.cpp index 34e2fe870..592f363b4 100644 --- a/src/cli/asn1.cpp +++ b/src/cli/asn1.cpp @@ -361,7 +361,7 @@ class ASN1_Printer final : public Command public: ASN1_Printer() : Command("asn1print file") {} - void go() + void go() override { Botan::DataSource_Stream in(get_arg("file")); diff --git a/src/cli/cc_enc.cpp b/src/cli/cc_enc.cpp index 6f19e546c..9a3256417 100644 --- a/src/cli/cc_enc.cpp +++ b/src/cli/cc_enc.cpp @@ -109,7 +109,7 @@ class CC_Encrypt final : public Command public: CC_Encrypt() : Command("cc_encrypt CC passphrase --tweak=") {} - void go() + void go() override { const uint64_t cc_number = std::stoull(get_arg("CC")); const std::vector<uint8_t> tweak = Botan::hex_decode(get_arg("tweak")); diff --git a/src/cli/utils.cpp b/src/cli/utils.cpp index 3f59ee923..199a7894f 100644 --- a/src/cli/utils.cpp +++ b/src/cli/utils.cpp @@ -237,7 +237,7 @@ class Generate_Bcrypt final : public Command public: Generate_Bcrypt() : Command("gen_bcrypt --work-factor=12 password") {} - void go() + void go() override { const std::string password = get_arg("password"); const size_t wf = get_arg_sz("work_factor"); @@ -253,7 +253,7 @@ class Check_Bcrypt final : public Command public: Check_Bcrypt() : Command("check_bcrypt password hash") {} - void go() + void go() override { const std::string password = get_arg("password"); const std::string hash = get_arg("hash"); |