Remove return value of AEAD_Mode::start as it doesn't seem necessary

and is an extra complication for callers.

Replace the get_aead in lookup.h returning a Filter with one in aead.h
returning AEAD_Mode.

2 files changed, 2 insertions, 4 deletions

diff --git a/src/aead/gcm/gcm.cpp b/src/aead/gcm/gcm.cpp
index 665fc4472..fbef36fee 100644
--- a/src/aead/gcm/gcm.cpp
+++ b/src/aead/gcm/gcm.cpp
@@ -153,7 +153,7 @@ void GCM_Mode::set_associated_data(const byte ad[], size_t ad_len)
    m_ad_len = ad_len;
    }
 
-secure_vector<byte> GCM_Mode::start(const byte nonce[], size_t nonce_len)
+void GCM_Mode::start(const byte nonce[], size_t nonce_len)
    {
    if(!valid_nonce_length(nonce_len))
       throw Invalid_IV_Length(name(), nonce_len);
@@ -178,8 +178,6 @@ secure_vector<byte> GCM_Mode::start(const byte nonce[], size_t nonce_len)
 
    m_text_len = 0;
    m_mac = m_H_ad;
-
-   return secure_vector<byte>();
    }
 
 void GCM_Encryption::update(secure_vector<byte>& buffer, size_t offset)
diff --git a/src/aead/gcm/gcm.h b/src/aead/gcm/gcm.h
index bc7eaae20..10a4a3497 100644
--- a/src/aead/gcm/gcm.h
+++ b/src/aead/gcm/gcm.h
@@ -21,7 +21,7 @@ namespace Botan {
 class BOTAN_DLL GCM_Mode : public AEAD_Mode
    {
    public:
-      secure_vector<byte> start(const byte nonce[], size_t nonce_len) override;
+      void start(const byte nonce[], size_t nonce_len) override;
 
       void set_associated_data(const byte ad[], size_t ad_len) override;