Require explicit calls to add_affine

Skipping the checks saves 3-7% for ECDSA

2 files changed, 2 insertions, 5 deletions

diff --git a/src/lib/pubkey/ec_group/point_gfp.cpp b/src/lib/pubkey/ec_group/point_gfp.cpp
index 7968d2dcd..6c7925367 100644
--- a/src/lib/pubkey/ec_group/point_gfp.cpp
+++ b/src/lib/pubkey/ec_group/point_gfp.cpp
@@ -76,7 +76,7 @@ void PointGFp::add_affine(const PointGFp& rhs, std::vector<BigInt>& ws_bn)
       return;
       }
 
-   BOTAN_ASSERT(rhs.is_affine(), "PointGFp::add_affine requires arg be affine point");
+   //BOTAN_ASSERT(rhs.is_affine(), "PointGFp::add_affine requires arg be affine point");
 
    /*
    https://hyperelliptic.org/EFD/g1p/auto-shortw-jacobian-3.html#addition-add-1998-cmo-2
@@ -167,9 +167,6 @@ void PointGFp::add(const PointGFp& rhs, std::vector<BigInt>& ws_bn)
    if(rhs.is_zero())
       return;
 
-   if(rhs.is_affine())
-      return this->add_affine(rhs, ws_bn);
-
    if(is_zero())
       {
       m_coord_x = rhs.m_coord_x;
diff --git a/src/lib/pubkey/ec_group/point_mul.cpp b/src/lib/pubkey/ec_group/point_mul.cpp
index 2a63a8221..132057643 100644
--- a/src/lib/pubkey/ec_group/point_mul.cpp
+++ b/src/lib/pubkey/ec_group/point_mul.cpp
@@ -88,7 +88,7 @@ PointGFp PointGFp_Base_Point_Precompute::mul(const BigInt& k,
          }
 
       if(scalar.get_bit(i))
-         R.add(m_T[i], ws);
+         R.add_affine(m_T[i], ws);
       }
 
    return R;