diff options
author | Frederick Ding <[email protected]> | 2019-02-27 22:09:24 +0000 |
---|---|---|
committer | John Stebbins <[email protected]> | 2019-02-28 06:25:07 -0800 |
commit | 22ee1a38eac473ce81d487f88ca58382abbaa0cb (patch) | |
tree | f6a7930c666b39c5b1776609a83d41e4d74ee50b /macosx/de.lproj/Subtitles.strings | |
parent | f60354ef7ece3c69a0c6e83021778c28270b2880 (diff) |
Fix Py3 compat and logic/syntax in handling version.txt
The first fix addresses the problem that readlines() gives back a
list of strings, which do not have the `.decode()` method that bytes do.
But `_parseSession()` is used both for the bytes output by running
`repo-info.sh` and for the strings output by ingesting `version.txt`.
So we still need to handle the bytes case.
The second fix addresses syntax and logic problems. If a string is
not empty, `if self.hash` will check that it's non-empty (I don't think
`is not empty` actually works -- it has given me a NameError). And the
string comparison should be done by value equality, not reference
equality.
Diffstat (limited to 'macosx/de.lproj/Subtitles.strings')
0 files changed, 0 insertions, 0 deletions