diff options
| author | John Stebbins <[email protected]> | 2017-03-10 12:56:55 -0700 |
|---|---|---|
| committer | GitHub <[email protected]> | 2017-03-10 12:56:55 -0700 |
| commit | bd22891d633e16d7aedddadd2e4dd716f615d847 (patch) | |
| tree | 4194d0fd483759f8e8f5226ac479e5ad193a9ef9 /macosx/HBTitle.m | |
| parent | 1f6c91c00be0f8f47de1d5c77b945ad6ecd50ec5 (diff) | |
subtitles: simplify and shorten subtitle descriptions (#591)
* subtitles: simplify and shorten subtitle descriptions
Generally, it eliminates parens to make things more readable.
I.e. it turns this:
English (Closed Caption)(Wide Screen)(Bitmap)(VOBSUB)
Into this:
English, Closed Caption [Wide Screen, VOBSUB]
* Revise punctuation per BradleyS request
* fix subtitle description formatting
* incorporate suggestions from PR
Diffstat (limited to 'macosx/HBTitle.m')
| -rw-r--r-- | macosx/HBTitle.m | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/macosx/HBTitle.m b/macosx/HBTitle.m index b07e7f270..25e3e8002 100644 --- a/macosx/HBTitle.m +++ b/macosx/HBTitle.m @@ -218,12 +218,10 @@ extern NSString *keySubTrackType; NSString *bitmapOrText = subtitle->format == PICTURESUB ? @"Bitmap" : @"Text"; NSString *subSourceName = @(hb_subsource_name(subtitle->source)); - // Use the native language name if available - iso639_lang_t *language = lang_for_code2(subtitle->iso639_2); - NSString *nativeLanguage = strlen(language->native_name) ? @(language->native_name) : @(language->eng_name); + NSString *lang = @(subtitle->lang); /* create a dictionary of source subtitle information to store in our array */ - [tracks addObject:@{keySubTrackName: [NSString stringWithFormat:@"%d: %@ (%@) (%@)", i, nativeLanguage, bitmapOrText, subSourceName], + [tracks addObject:@{keySubTrackName: [NSString stringWithFormat:@"%d: %@", i, lang], keySubTrackType: @(subtitle->source), keySubTrackLanguageIsoCode: @(subtitle->iso639_2)}]; } |