Fixating certain enums -> 'enum class' (localizing enum scope avoiding duplicates)

Localizing enum scope avoiding duplicates also helps fixating type safety.

This is especially important for short enums w/o a type prefix.

+++

Fixes:
- MgmtEvent::getSpecialized(..): Reading actual uint16_t Opcode instead of just peeking uint8_t! (Duh!)
- MgmtEvent* *string* ops: Converting uint16_t Opcode instead of uint8_t to string.

1 files changed, 2 insertions, 1 deletions

diff --git a/src/direct_bt/GATTNumbers.cpp b/src/direct_bt/GATTNumbers.cpp
index 3535a0c9..11287968 100644
--- a/src/direct_bt/GATTNumbers.cpp
+++ b/src/direct_bt/GATTNumbers.cpp
@@ -368,7 +368,8 @@ std::string PeriphalPreferredConnectionParameters::toString() const {
 }
 
 std::string GenericAccess::toString() const {
-    return "'"+deviceName+"'[appearance "+uint16HexString(appearance)+" ("+AppearanceCatToString(appearance)+"), "+prefConnParam.toString()+"]";
+    return "'"+deviceName+"'[appearance "+uint16HexString(static_cast<uint16_t>(appearance))+" ("+AppearanceCatToString(appearance)+"), "+
+            prefConnParam.toString()+"]";
 }
 
 PnP_ID::PnP_ID(const TROOctets &source)