summaryrefslogtreecommitdiffstats
path: root/module/splat/splat-mutex.c
blob: 5c039236e82da2dc243ea99bae2b01babe5cb543 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
/*
 *  This file is part of the SPL: Solaris Porting Layer.
 *
 *  Copyright (c) 2008 Lawrence Livermore National Security, LLC.
 *  Produced at Lawrence Livermore National Laboratory
 *  Written by:
 *          Brian Behlendorf <behlendorf1@llnl.gov>,
 *          Herb Wartens <wartens2@llnl.gov>,
 *          Jim Garlick <garlick@llnl.gov>
 *  UCRL-CODE-235197
 *
 *  This is free software; you can redistribute it and/or modify it
 *  under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2 of the License, or
 *  (at your option) any later version.
 *
 *  This is distributed in the hope that it will be useful, but WITHOUT
 *  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 *  FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
 *  for more details.
 *
 *  You should have received a copy of the GNU General Public License along
 *  with this program; if not, write to the Free Software Foundation, Inc.,
 *  51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA.
 */

#include "splat-internal.h"

#define SPLAT_SUBSYSTEM_MUTEX		0x0400
#define SPLAT_MUTEX_NAME		"mutex"
#define SPLAT_MUTEX_DESC		"Kernel Mutex Tests"

#define SPLAT_MUTEX_TEST1_ID		0x0401
#define SPLAT_MUTEX_TEST1_NAME		"tryenter"
#define SPLAT_MUTEX_TEST1_DESC		"Validate mutex_tryenter() correctness"

#define SPLAT_MUTEX_TEST2_ID		0x0402
#define SPLAT_MUTEX_TEST2_NAME		"race"
#define SPLAT_MUTEX_TEST2_DESC		"Many threads entering/exiting the mutex"

#define SPLAT_MUTEX_TEST3_ID		0x0403
#define SPLAT_MUTEX_TEST3_NAME		"owned"
#define SPLAT_MUTEX_TEST3_DESC		"Validate mutex_owned() correctness"

#define SPLAT_MUTEX_TEST4_ID		0x0404
#define SPLAT_MUTEX_TEST4_NAME		"owner"
#define SPLAT_MUTEX_TEST4_DESC		"Validate mutex_owner() correctness"

#define SPLAT_MUTEX_TEST_MAGIC		0x115599DDUL
#define SPLAT_MUTEX_TEST_NAME		"mutex_test"
#define SPLAT_MUTEX_TEST_TASKQ		"mutex_taskq"
#define SPLAT_MUTEX_TEST_COUNT		128

typedef struct mutex_priv {
        unsigned long mp_magic;
        struct file *mp_file;
	kmutex_t mp_mtx;
	int mp_rc;
} mutex_priv_t;

static void
splat_mutex_test1_func(void *arg)
{
	mutex_priv_t *mp = (mutex_priv_t *)arg;
	ASSERT(mp->mp_magic == SPLAT_MUTEX_TEST_MAGIC);

	if (mutex_tryenter(&mp->mp_mtx)) {
		mp->mp_rc = 0;
		mutex_exit(&mp->mp_mtx);
	} else {
		mp->mp_rc = -EBUSY;
	}
}

static int
splat_mutex_test1(struct file *file, void *arg)
{
	mutex_priv_t *mp;
	taskq_t *tq;
	int id, rc = 0;

	mp = (mutex_priv_t *)kmalloc(sizeof(*mp), GFP_KERNEL);
	if (mp == NULL)
		return -ENOMEM;

	tq = taskq_create(SPLAT_MUTEX_TEST_TASKQ, 1, maxclsyspri,
			  50, INT_MAX, TASKQ_PREPOPULATE);
	if (tq == NULL) {
		rc = -ENOMEM;
		goto out2;
	}

	mp->mp_magic = SPLAT_MUTEX_TEST_MAGIC;
	mp->mp_file = file;
	mutex_init(&mp->mp_mtx, SPLAT_MUTEX_TEST_NAME, MUTEX_DEFAULT, NULL);
	mutex_enter(&mp->mp_mtx);

	/*
	 * Schedule a task function which will try and acquire the mutex via
	 * mutex_tryenter() while it's held.  This should fail and the task
	 * function will indicate this status in the passed private data.
	 */
	mp->mp_rc = -EINVAL;
	id = taskq_dispatch(tq, splat_mutex_test1_func, mp, TQ_SLEEP);
	if (id == 0) {
		mutex_exit(&mp->mp_mtx);
		splat_vprint(file, SPLAT_MUTEX_TEST1_NAME, "%s",
		             "taskq_dispatch() failed\n");
		rc = -EINVAL;
		goto out;
	}

	taskq_wait_id(tq, id);
	mutex_exit(&mp->mp_mtx);

	/* Task function successfully acquired mutex, very bad! */
	if (mp->mp_rc != -EBUSY) {
		splat_vprint(file, SPLAT_MUTEX_TEST1_NAME,
		             "mutex_trylock() incorrectly succeeded when "
			     "the mutex was held, %d/%d\n", id, mp->mp_rc);
		rc = -EINVAL;
		goto out;
	} else {
		splat_vprint(file, SPLAT_MUTEX_TEST1_NAME, "%s",
			     "mutex_trylock() correctly failed when "
		             "the mutex was held\n");
	}

	/*
	 * Schedule a task function which will try and acquire the mutex via
	 * mutex_tryenter() while it is not held.  This should succeed and
	 * can be verified by checking the private data.
	 */
	mp->mp_rc = -EINVAL;
	id = taskq_dispatch(tq, splat_mutex_test1_func, mp, TQ_SLEEP);
	if (id == 0) {
		splat_vprint(file, SPLAT_MUTEX_TEST1_NAME, "%s",
		             "taskq_dispatch() failed\n");
		rc = -EINVAL;
		goto out;
	}

	taskq_wait_id(tq, id);

	/* Task function failed to acquire mutex, very bad! */
	if (mp->mp_rc != 0) {
		splat_vprint(file, SPLAT_MUTEX_TEST1_NAME,
			     "mutex_trylock() incorrectly failed when "
			     "the mutex was not held, %d/%d\n", id, mp->mp_rc);
		rc = -EINVAL;
	} else {
		splat_vprint(file, SPLAT_MUTEX_TEST1_NAME, "%s",
			     "mutex_trylock() correctly succeeded "
			     "when the mutex was not held\n");
	}
out:
	taskq_destroy(tq);
	mutex_destroy(&(mp->mp_mtx));
out2:
	kfree(mp);
	return rc;
}

static void
splat_mutex_test2_func(void *arg)
{
	mutex_priv_t *mp = (mutex_priv_t *)arg;
	int rc;
	ASSERT(mp->mp_magic == SPLAT_MUTEX_TEST_MAGIC);

	/* Read the value before sleeping and write it after we wake up to
	 * maximize the chance of a race if mutexs are not working properly */
	mutex_enter(&mp->mp_mtx);
	rc = mp->mp_rc;
	set_current_state(TASK_INTERRUPTIBLE);
	schedule_timeout(HZ / 100);  /* 1/100 of a second */
	VERIFY(mp->mp_rc == rc);
	mp->mp_rc = rc + 1;
	mutex_exit(&mp->mp_mtx);
}

static int
splat_mutex_test2(struct file *file, void *arg)
{
	mutex_priv_t *mp;
	taskq_t *tq;
	int i, rc = 0;

	mp = (mutex_priv_t *)kmalloc(sizeof(*mp), GFP_KERNEL);
	if (mp == NULL)
		return -ENOMEM;

	/* Create several threads allowing tasks to race with each other */
	tq = taskq_create(SPLAT_MUTEX_TEST_TASKQ, num_online_cpus(),
			  maxclsyspri, 50, INT_MAX, TASKQ_PREPOPULATE);
	if (tq == NULL) {
		rc = -ENOMEM;
		goto out;
	}

	mp->mp_magic = SPLAT_MUTEX_TEST_MAGIC;
	mp->mp_file = file;
	mutex_init(&(mp->mp_mtx), SPLAT_MUTEX_TEST_NAME, MUTEX_DEFAULT, NULL);
	mp->mp_rc = 0;

	/*
	 * Schedule N work items to the work queue each of which enters the
	 * mutex, sleeps briefly, then exits the mutex.  On a multiprocessor
	 * box these work items will be handled by all available CPUs.  The
	 * task function checks to ensure the tracked shared variable is
	 * always only incremented by one.  Additionally, the mutex itself
	 * is instrumented such that if any two processors are in the
	 * critical region at the same time the system will panic.  If the
	 * mutex is implemented right this will never happy, that's a pass.
	 */
	for (i = 0; i < SPLAT_MUTEX_TEST_COUNT; i++) {
		if (!taskq_dispatch(tq, splat_mutex_test2_func, mp, TQ_SLEEP)) {
		        splat_vprint(file, SPLAT_MUTEX_TEST2_NAME,
			             "Failed to queue task %d\n", i);
			rc = -EINVAL;
		}
	}

	taskq_wait(tq);

	if (mp->mp_rc == SPLAT_MUTEX_TEST_COUNT) {
	        splat_vprint(file, SPLAT_MUTEX_TEST2_NAME, "%d racing threads "
			   "correctly entered/exited the mutex %d times\n",
			   num_online_cpus(), mp->mp_rc);
	} else {
	        splat_vprint(file, SPLAT_MUTEX_TEST2_NAME, "%d racing threads "
			   "only processed %d/%d mutex work items\n",
			   num_online_cpus(),mp->mp_rc,SPLAT_MUTEX_TEST_COUNT);
		rc = -EINVAL;
	}

	taskq_destroy(tq);
	mutex_destroy(&(mp->mp_mtx));
out:
	kfree(mp);
	return rc;
}

static int
splat_mutex_test3(struct file *file, void *arg)
{
        kmutex_t mtx;
	int rc = 0;

	mutex_init(&mtx, SPLAT_MUTEX_TEST_NAME, MUTEX_DEFAULT, NULL);

	mutex_enter(&mtx);

	/* Mutex should be owned by current */
	if (!mutex_owned(&mtx)) {
	        splat_vprint(file, SPLAT_MUTEX_TEST3_NAME, "Mutex should "
			   "be owned by pid %d but is owned by pid %d\n",
			   current->pid, mtx.km_owner ?  mtx.km_owner->pid : -1);
		rc = -EINVAL;
		goto out;
	}

	mutex_exit(&mtx);

	/* Mutex should not be owned by any task */
	if (mutex_owned(&mtx)) {
	        splat_vprint(file, SPLAT_MUTEX_TEST3_NAME, "Mutex should "
			   "not be owned but is owned by pid %d\n",
			   mtx.km_owner ?  mtx.km_owner->pid : -1);
		rc = -EINVAL;
		goto out;
	}

        splat_vprint(file, SPLAT_MUTEX_TEST3_NAME, "%s",
		   "Correct mutex_owned() behavior\n");
out:
	mutex_destroy(&mtx);

	return rc;
}

static int
splat_mutex_test4(struct file *file, void *arg)
{
        kmutex_t mtx;
	kthread_t *owner;
	int rc = 0;

	mutex_init(&mtx, SPLAT_MUTEX_TEST_NAME, MUTEX_DEFAULT, NULL);

	mutex_enter(&mtx);

	/* Mutex should be owned by current */
	owner = mutex_owner(&mtx);
	if (current != owner) {
	        splat_vprint(file, SPLAT_MUTEX_TEST3_NAME, "Mutex should "
			   "be owned by pid %d but is owned by pid %d\n",
			   current->pid, owner ? owner->pid : -1);
		rc = -EINVAL;
		goto out;
	}

	mutex_exit(&mtx);

	/* Mutex should not be owned by any task */
	owner = mutex_owner(&mtx);
	if (owner) {
	        splat_vprint(file, SPLAT_MUTEX_TEST3_NAME, "Mutex should not "
			   "be owned but is owned by pid %d\n", owner->pid);
		rc = -EINVAL;
		goto out;
	}

        splat_vprint(file, SPLAT_MUTEX_TEST3_NAME, "%s",
		   "Correct mutex_owner() behavior\n");
out:
	mutex_destroy(&mtx);

	return rc;
}

splat_subsystem_t *
splat_mutex_init(void)
{
        splat_subsystem_t *sub;

        sub = kmalloc(sizeof(*sub), GFP_KERNEL);
        if (sub == NULL)
                return NULL;

        memset(sub, 0, sizeof(*sub));
        strncpy(sub->desc.name, SPLAT_MUTEX_NAME, SPLAT_NAME_SIZE);
        strncpy(sub->desc.desc, SPLAT_MUTEX_DESC, SPLAT_DESC_SIZE);
        INIT_LIST_HEAD(&sub->subsystem_list);
        INIT_LIST_HEAD(&sub->test_list);
        spin_lock_init(&sub->test_lock);
        sub->desc.id = SPLAT_SUBSYSTEM_MUTEX;

        SPLAT_TEST_INIT(sub, SPLAT_MUTEX_TEST1_NAME, SPLAT_MUTEX_TEST1_DESC,
                      SPLAT_MUTEX_TEST1_ID, splat_mutex_test1);
        SPLAT_TEST_INIT(sub, SPLAT_MUTEX_TEST2_NAME, SPLAT_MUTEX_TEST2_DESC,
                      SPLAT_MUTEX_TEST2_ID, splat_mutex_test2);
        SPLAT_TEST_INIT(sub, SPLAT_MUTEX_TEST3_NAME, SPLAT_MUTEX_TEST3_DESC,
                      SPLAT_MUTEX_TEST3_ID, splat_mutex_test3);
        SPLAT_TEST_INIT(sub, SPLAT_MUTEX_TEST4_NAME, SPLAT_MUTEX_TEST4_DESC,
                      SPLAT_MUTEX_TEST4_ID, splat_mutex_test4);

        return sub;
}

void
splat_mutex_fini(splat_subsystem_t *sub)
{
        ASSERT(sub);
        SPLAT_TEST_FINI(sub, SPLAT_MUTEX_TEST4_ID);
        SPLAT_TEST_FINI(sub, SPLAT_MUTEX_TEST3_ID);
        SPLAT_TEST_FINI(sub, SPLAT_MUTEX_TEST2_ID);
        SPLAT_TEST_FINI(sub, SPLAT_MUTEX_TEST1_ID);

        kfree(sub);
}

int
splat_mutex_id(void) {
        return SPLAT_SUBSYSTEM_MUTEX;
}