From b7ab7ae2410f5152318cbb71675e9ba94d7562cb Mon Sep 17 00:00:00 2001 From: Ryan Moeller Date: Fri, 9 Oct 2020 12:27:14 -0400 Subject: Linux: Initialize zp in zfs_setattr_dir The value of zp is used without having been initialized under some conditions. Initialize the pointer to NULL. Add a regression test case using chown in acl/posix. However, this is not enough because the setup sets xattr=sa, which means zfs_setattr_dir will not be called. Create a second group of acl tests in acl/posix-sa duplicating the acl/posix tests with symlinks, and remove xattr=sa from the original acl/posix tests. This provides more coverage for the default xattr=on code. Reviewed-by: Brian Behlendorf Signed-off-by: Ryan Moeller Closes #10043 Closes #11025 --- tests/runfiles/linux.run | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'tests/runfiles/linux.run') diff --git a/tests/runfiles/linux.run b/tests/runfiles/linux.run index 94964434e..ac4d6af1c 100644 --- a/tests/runfiles/linux.run +++ b/tests/runfiles/linux.run @@ -23,9 +23,13 @@ outputdir = /var/tmp/test_results tags = ['functional'] [tests/functional/acl/posix:Linux] -tests = ['posix_001_pos', 'posix_002_pos', 'posix_003_pos'] +tests = ['posix_001_pos', 'posix_002_pos', 'posix_003_pos', 'posix_004_pos'] tags = ['functional', 'acl', 'posix'] +[tests/functional/acl/posix-sa:Linux] +tests = ['posix_001_pos', 'posix_002_pos', 'posix_003_pos', 'posix_004_pos'] +tags = ['functional', 'acl', 'posix-sa'] + [tests/functional/atime:Linux] tests = ['atime_003_pos', 'root_relatime_on'] tags = ['functional', 'atime'] -- cgit v1.2.3