From 3d8d245fb3f1724488c972658da2aab9e8528210 Mon Sep 17 00:00:00 2001 From: Brian Behlendorf Date: Mon, 16 Nov 2015 15:00:38 -0800 Subject: Follow 0/-E convention for module load errors Because errors during module load are so rare it went unnoticed that it was possible that a positive errno was returned. This would result in the module being loaded, nothing being initialized, and a system panic shortly thereafter. This is what was causing the hard failures in the automated testing. Signed-off-by: Brian Behlendorf --- module/zfs/zfs_ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'module') diff --git a/module/zfs/zfs_ioctl.c b/module/zfs/zfs_ioctl.c index 7ce19693e..d026e92d6 100644 --- a/module/zfs/zfs_ioctl.c +++ b/module/zfs/zfs_ioctl.c @@ -6011,7 +6011,7 @@ _init(void) { int error; - error = vn_set_pwd("/"); + error = -vn_set_pwd("/"); if (error) { printk(KERN_NOTICE "ZFS: Warning unable to set pwd to '/': %d\n", error); @@ -6021,7 +6021,7 @@ _init(void) spa_init(FREAD | FWRITE); zfs_init(); - if ((error = zvol_init()) != 0) + if ((error = -zvol_init()) != 0) goto out1; zfs_ioctl_init(); -- cgit v1.2.3