From 327000ce04b4243f140a38647dca59683d39b8e7 Mon Sep 17 00:00:00 2001 From: Dirkjan Bussink Date: Tue, 25 Feb 2020 00:38:23 +0100 Subject: Remove zfs_getattr and convoff dead code The `convoff` function is called only in one code path in `zfs_space`. Each caller of `zfs_space` is called with a `flock64_t` that has `l_whence` set to `SEEK_SET`. This means that `convoff` always results in a no-op as the `bfp` parameter has `l_whence` set to `SEEK_SET` and `int whence` is `SEEK_SET` as well. Reviewed-by: Brian Behlendorf Reviewed-by: Ryan Moeller Signed-off-by: Dirkjan Bussink Closes #10006 --- module/zfs/dmu.c | 1 - 1 file changed, 1 deletion(-) (limited to 'module/zfs') diff --git a/module/zfs/dmu.c b/module/zfs/dmu.c index ba3c39af0..aa392b177 100644 --- a/module/zfs/dmu.c +++ b/module/zfs/dmu.c @@ -2365,7 +2365,6 @@ dmu_object_info_from_db(dmu_buf_t *db_fake, dmu_object_info_t *doi) /* * Faster still when you only care about the size. - * This is specifically optimized for zfs_getattr(). */ void dmu_object_size_from_db(dmu_buf_t *db_fake, uint32_t *blksize, -- cgit v1.2.3