From a887d653b32aaba3fe04c7b25ff0091b9ea9c64e Mon Sep 17 00:00:00 2001 From: Sara Hartse Date: Thu, 4 Apr 2019 18:57:06 -0700 Subject: Restrict kstats and print real pointers There are several places where we use zfs_dbgmsg and %p to print pointers. In the Linux kernel, these values obfuscated to prevent information leaks which means the pointers aren't very useful for debugging crash dumps. We decided to restrict the permissions of dbgmsg (and some other kstats while we were at it) and print pointers with %px in zfs_dbgmsg as well as spl_dumpstack Reviewed-by: Brian Behlendorf Reviewed-by: John Gallagher Signed-off-by: sara hartse Closes #8467 Closes #8476 --- module/zfs/metaslab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'module/zfs/metaslab.c') diff --git a/module/zfs/metaslab.c b/module/zfs/metaslab.c index 06d8383f0..ec89810b4 100644 --- a/module/zfs/metaslab.c +++ b/module/zfs/metaslab.c @@ -2643,7 +2643,7 @@ metaslab_condense(metaslab_t *msp, uint64_t txg, dmu_tx_t *tx) ASSERT(msp->ms_loaded); - zfs_dbgmsg("condensing: txg %llu, msp[%llu] %p, vdev id %llu, " + zfs_dbgmsg("condensing: txg %llu, msp[%llu] %px, vdev id %llu, " "spa %s, smp size %llu, segments %lu, forcing condense=%s", txg, msp->ms_id, msp, msp->ms_group->mg_vd->vdev_id, msp->ms_group->mg_vd->vdev_spa->spa_name, -- cgit v1.2.3