From b7ab7ae2410f5152318cbb71675e9ba94d7562cb Mon Sep 17 00:00:00 2001 From: Ryan Moeller Date: Fri, 9 Oct 2020 12:27:14 -0400 Subject: Linux: Initialize zp in zfs_setattr_dir The value of zp is used without having been initialized under some conditions. Initialize the pointer to NULL. Add a regression test case using chown in acl/posix. However, this is not enough because the setup sets xattr=sa, which means zfs_setattr_dir will not be called. Create a second group of acl tests in acl/posix-sa duplicating the acl/posix tests with symlinks, and remove xattr=sa from the original acl/posix tests. This provides more coverage for the default xattr=on code. Reviewed-by: Brian Behlendorf Signed-off-by: Ryan Moeller Closes #10043 Closes #11025 --- man/man8/zfsprops.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'man') diff --git a/man/man8/zfsprops.8 b/man/man8/zfsprops.8 index 2c4a2af29..a3392d6c0 100644 --- a/man/man8/zfsprops.8 +++ b/man/man8/zfsprops.8 @@ -1794,7 +1794,7 @@ on platforms which do not support the feature. .Pp The use of system attribute based xattrs is strongly encouraged for users of -SELinux or POSIX ACLs. Both of these features heavily rely of extended +SELinux or POSIX ACLs. Both of these features heavily rely on extended attributes and benefit significantly from the reduced access time. .Pp The values -- cgit v1.2.3