From 32a9872bbae90a7cd9793c371f558701ec268976 Mon Sep 17 00:00:00 2001 From: George Wilson Date: Thu, 3 May 2012 05:49:19 -0700 Subject: Illumos #2671: zpool import should not fail if vdev ashift has increased Reviewed by: Adam Leventhal Reviewed by: Eric Schrock Reviewed by: Richard Elling Reviewed by: Gordon Ross Reviewed by: Garrett D'Amore Approved by: Richard Lowe Refererces to Illumos issue: https://www.illumos.org/issues/2671 This patch has been slightly modified from the upstream Illumos version. In the upstream implementation a warning message is logged to the console. To prevent pointless console noise this notification is now posted as a "ereport.fs.zfs.vdev.bad_ashift" event. The event indicates a non-optimial (but entirely safe) ashift value was used to create the pool. Depending on your workload this may impact pool performance. Unfortunately, the only way to correct the issue is to recreate the pool with a new ashift. NOTE: The unrelated fix to the comment in zpool_main.c appears in the upstream commit and was preserved for consistnecy. Ported-by: Cyril Plisko Reworked-by: Brian Behlendorf Closes #955 --- cmd/zpool/zpool_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'cmd/zpool') diff --git a/cmd/zpool/zpool_main.c b/cmd/zpool/zpool_main.c index 56617323f..96798c4ad 100644 --- a/cmd/zpool/zpool_main.c +++ b/cmd/zpool/zpool_main.c @@ -3736,7 +3736,7 @@ print_dedup_stats(nvlist_t *config) /* * If the pool was faulted then we may not have been able to - * obtain the config. Otherwise, if have anything in the dedup + * obtain the config. Otherwise, if we have anything in the dedup * table continue processing the stats. */ if (nvlist_lookup_uint64_array(config, ZPOOL_CONFIG_DDT_OBJ_STATS, -- cgit v1.2.3