From 884385a0b25dc36b622e5e427bf29281c3dbca06 Mon Sep 17 00:00:00 2001 From: cao Date: Wed, 21 Sep 2016 08:45:45 +0800 Subject: Fix coverity defects Fix coverity defects: coverity scan CID:147623, Type: Resource leak. coverity scan CID:147622, Type: Resource leak. reason: zpool_open zhp, but not zpool_close zhp. so resource leak. coverity scan CID:147621, Type: Resource fd leak. coverity scan CID:147620, Type: Resource fd leak. reason: do_write do_read open file fd,but exception not close fd. delete unuse definition DMU_OS_IS_L2COMPRESSIBLE. Reviewed-by: Brian Behlendorf Signed-off-by: cao.xuewen Closes #5137 --- cmd/zinject/translate.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'cmd/zinject') diff --git a/cmd/zinject/translate.c b/cmd/zinject/translate.c index adace72ff..1aef074d3 100644 --- a/cmd/zinject/translate.c +++ b/cmd/zinject/translate.c @@ -474,6 +474,7 @@ translate_device(const char *pool, const char *device, err_type_t label_type, if (tgt == NULL) { (void) fprintf(stderr, "cannot find device '%s' in " "pool '%s'\n", device, pool); + zpool_close(zhp); return (-1); } @@ -515,5 +516,6 @@ translate_device(const char *pool, const char *device, err_type_t label_type, record->zi_end = record->zi_start + VDEV_PAD_SIZE - 1; break; } + zpool_close(zhp); return (0); } -- cgit v1.2.3