From 3c832b8cc13bb4e570b317c30b146bb072e08f58 Mon Sep 17 00:00:00 2001 From: Tim Chase Date: Thu, 18 Dec 2014 10:08:47 -0600 Subject: Linux 3.12 compat: split shrinker has s_shrink The split count/scan shrinker callbacks introduced in 3.12 broke the test for HAVE_SHRINK, effectively disabling the per-superblock shrinkers. This patch re-enables the per-superblock shrinkers when the split shrinker callbacks have been detected. Signed-off-by: Tim Chase Signed-off-by: Brian Behlendorf Closes #2975 --- module/zfs/zfs_vfsops.c | 8 ++++++-- module/zfs/zpl_super.c | 8 ++++---- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/module/zfs/zfs_vfsops.c b/module/zfs/zfs_vfsops.c index d29fc6560..a2dea89b7 100644 --- a/module/zfs/zfs_vfsops.c +++ b/module/zfs/zfs_vfsops.c @@ -1068,7 +1068,7 @@ zfs_root(zfs_sb_t *zsb, struct inode **ipp) } EXPORT_SYMBOL(zfs_root); -#ifdef HAVE_SHRINK +#if defined(HAVE_SHRINK) || defined(HAVE_SPLIT_SHRINKER_CALLBACK) int zfs_sb_prune(struct super_block *sb, unsigned long nr_to_scan, int *objects) { @@ -1080,13 +1080,17 @@ zfs_sb_prune(struct super_block *sb, unsigned long nr_to_scan, int *objects) }; ZFS_ENTER(zsb); +#ifdef HAVE_SPLIT_SHRINKER_CALLBACK + *objects = (*shrinker->scan_objects)(shrinker, &sc); +#else *objects = (*shrinker->shrink)(shrinker, &sc); +#endif ZFS_EXIT(zsb); return (0); } EXPORT_SYMBOL(zfs_sb_prune); -#endif /* HAVE_SHRINK */ +#endif /* defined(HAVE_SHRINK) || defined(HAVE_SPLIT_SHRINKER_CALLBACK) */ /* * Teardown the zfs_sb_t. diff --git a/module/zfs/zpl_super.c b/module/zfs/zpl_super.c index 410030461..aa234bcff 100644 --- a/module/zfs/zpl_super.c +++ b/module/zfs/zpl_super.c @@ -268,7 +268,7 @@ zpl_kill_sb(struct super_block *sb) #endif /* HAVE_S_INSTANCES_LIST_HEAD */ } -#ifdef HAVE_SHRINK +#if defined(HAVE_SHRINK) || defined(HAVE_SPLIT_SHRINKER_CALLBACK) /* * Linux 3.1 - 3.x API * @@ -288,17 +288,17 @@ zpl_prune_sb(struct super_block *sb, void *arg) error = -zfs_sb_prune(sb, *(unsigned long *)arg, &objects); ASSERT3S(error, <=, 0); } -#endif /* HAVE_SHRINK */ +#endif /* defined(HAVE_SHRINK) || defined(HAVE_SPLIT_SHRINKER_CALLBACK) */ void zpl_prune_sbs(int64_t bytes_to_scan, void *private) { -#ifdef HAVE_SHRINK +#if defined(HAVE_SHRINK) || defined(HAVE_SPLIT_SHRINKER_CALLBACK) unsigned long nr_to_scan = (bytes_to_scan / sizeof (znode_t)); iterate_supers_type(&zpl_fs_type, zpl_prune_sb, &nr_to_scan); kmem_reap(); -#endif /* HAVE_SHRINK */ +#endif /* defined(HAVE_SHRINK) || defined(HAVE_SPLIT_SHRINKER_CALLBACK) */ } #ifdef HAVE_NR_CACHED_OBJECTS -- cgit v1.2.3