summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Enhanse the thread interface to do something quasi inteligentbehlendo2008-05-122-3/+24
| | | | | | | | | | | | with the function name passed to be used as a thread name. Leaving the trailing _thread is just redundant so just strip it this make the thread names far more readable. Use a strncpy in spl-mutex just to be safe. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@107 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Add a comment so I remember to fix this.behlendo2008-05-121-0/+5
| | | | git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@106 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* By default disable extra KMEM and MUTEX debugging to aid performance.behlendo2008-05-095-17/+31
| | | | | | | | They can easily be re-enabled when new stability issues are uncovered. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@105 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Stability hack. Under Solaris when KM_SLEEP is set kmem_cache_alloc()behlendo2008-05-093-6/+43
| | | | | | | | | | | may not fail. To get this behavior I'd added a retry to the shim layer even though it is abusive to the VM, at least it should prevent the crash. Additionally I added a proc counter so I can easily check how often this is happening. It should be fairly rare, but likely will get worse and worse the longer the machine has been up. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@104 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Add an almost feature complete implemenation of kstat. I chosebehlendo2008-05-086-110/+664
| | | | | | | | | | not to support a few flags (we assert if they are used), and I did not add the libkstat interface and instead exported everything to proc for easy access. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@103 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Same deal as ZFS, we're quite stable now so tag it.behlendo2008-05-072-2/+2
| | | | git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@101 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Decrease of kmem warnign threshold back to 2 pages, no worse than a stack.behlendo2008-05-071-2/+3
| | | | git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@100 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Add vmem memory accountingbehlendo2008-05-072-33/+103
| | | | git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@99 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* - Relocate 'stats_per' in to proper /proc/sys/spl/mutex/ directorybehlendo2008-05-073-34/+67
| | | | | | | | - Shift to spinlock for mutex list addition and removal git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@98 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Remaining issues fixed after reenabled mutex debugging.behlendo2008-05-062-5/+13
| | | | | | | | | - Ensure the mutex_stats_sem and mutex_stats_list are initialized - Only spin if you have to in mutex_init git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@97 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* - Updated rwlock's to reside in a .c file instead of a static inlinebehlendo2008-05-063-283/+321
| | | | | | | | - Updated rwlock's so they can be safely initialized in ctors. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@96 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Lots of fixes here:behlendo2008-05-066-79/+303
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Detailed kmem memory allocation tracking. We can now get on spl module unload a list of all memory allocations which were not free'd and where the original alloc was. E.g. SPL: 15554:632:(spl-kmem.c:442:kmem_fini()) kmem leaked 90/319332 bytes SPL: 15554:648:(spl-kmem.c:451:kmem_fini()) address size data func:line SPL: 15554:648:(spl-kmem.c:457:kmem_fini()) ffff8100734b68b8 32 0100000001005a5a __spl_mutex_init:70 SPL: 15554:648:(spl-kmem.c:457:kmem_fini()) ffff8100734b6148 13 &tl->tl_lock __spl_mutex_init:74 SPL: 15554:648:(spl-kmem.c:457:kmem_fini()) ffff81007ac43730 32 0100000001005a5a __spl_mutex_init:70 SPL: 15554:648:(spl-kmem.c:457:kmem_fini()) ffff81007ac437d8 13 &tl->tl_lock __spl_mutex_init:74 - Shift to using rwsems in kmem implmentation, to simply locking and improve concurency. - Shift to using rwsems in mutex implementation, additionally ensure we never sleep in the init function if non-zero preempt_count or interrupts are disabled as can happen in a slab cache ctor/dtor. - Other minor formating fixes and such. TODO: - Finish the vmem memory allocation tracking - Vet all other SPL primatives for potential sleeping during *_init. I suspect the rwlock implemenation does this and should be fixes just like the mutex implemenation. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@95 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Commit adaptive mutexes. This seems to have introduced some newbehlendo2008-05-059-201/+561
| | | | | | | | | | | | | crashes but it's not clear to me yet if these are a problem with the mutex implementation or ZFSs usage of it. Minor taskq fixes to add new tasks to the end of the pending list. Minor enhansements to the debug infrastructure. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@94 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* New an improved taskq implementation for the SPL. It allows abehlendo2008-04-255-139/+484
| | | | | | | | | | | configurable number of threads like the Solaris version and almost all of the options are supported. Unfortunately, it appears to have made absolutely no difference to our performance numbers. I need to keep looking for where we are bottle necking. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@93 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Update kmem.h to properly use new debug subsystem.behlendo2008-04-242-11/+24
| | | | git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@92 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Prep for 0.2.1 tagbehlendo2008-04-248-24/+50
| | | | | | | | | Minor fixes to headers to use debug macros Added /proc/sys/spl/version git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@90 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Forgot to update the ChangeLog.wartens22008-04-241-0/+7
| | | | git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@89 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Make sure that when calling __vmem_alloc that wewartens22008-04-241-2/+5
| | | | | | | | | do not have __GFP_ZERO set. Once the memory is allocated then zero out the memory if __GFP_ZERO is passed to __vmem_alloc. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@88 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Minor improvement to taskq handling. This is a small step towardsbehlendo2008-04-232-7/+17
| | | | | | | dynamic taskqs which still need to be fully implemented. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@87 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Be careful to never use any of the debug infrastructure eitherbehlendo2008-04-221-5/+2
| | | | | | | | | before the debug subsystem is fully set up, or after the debug subsystem has been torn down. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@86 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Give it a real version for a tagbehlendo2008-04-222-2/+2
| | | | git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@84 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Stack usage is my enemy. Trade cpu cycles in the debug code tobehlendo2008-04-223-62/+55
| | | | | | | | | | | | | | | | | ensure I never add anything to the stack I don't absolutely need. All this debug code could be removed from a production build anyway so I'm not so worried about the performance impact. We may also consider revisting the mutex and condvar implementation to ensure no additional stack is used there. Initial indications are I have reduced the worst case stack usage to 9080 bytes. Still to large for the default 8k stacks so I have been forced to run with 16k stacks until I can reduce the worst offenders. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@83 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* More fixes to ensure we get good debug logs even if we're in thebehlendo2008-04-213-53/+63
| | | | | | | | | process of destroying the stacks. Threshhold set fairly aggressively top 80% of stack usage. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@82 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Added 4 missing subsystem flagsbehlendo2008-04-211-0/+8
| | | | git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@81 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Whoops, missed an instance where we could recursively stack check... bad.behlendo2008-04-211-3/+2
| | | | git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@80 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Handful of minor stack checking fixesbehlendo2008-04-213-8/+9
| | | | git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@79 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Update SPL to use new debug infrastructure. This means:behlendo2008-04-2123-271/+410
| | | | | | | | | - Replacing all BUG_ON()'s with proper ASSERT()'s - Using ENTRY,EXIT,GOTO, and RETURN macro to instument call paths git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@78 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Frist minor batch of fixes. Catch a dropped ;, and use SBUG instead of BUG.behlendo2008-04-192-5/+6
| | | | git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@77 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Whoops need this!behlendo2008-04-181-0/+21
| | | | git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@76 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* First commit of lustre style internal debug support. Thesebehlendo2008-04-1810-337/+2464
| | | | | | | | | | | | | | | | | changes bring over everything lustre had for debugging with two exceptions. I dropped by the debug daemon and upcalls just because it made things a little easier. They can be readded easily enough if we feel they are needed. Everything compiles and seems to work on first inspection but I suspect there are a handful of issues still lingering which I'll be sorting out right away. I just wanted to get all these changes commited and safe. I'm getting a little paranoid about losing them. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@75 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* * modules/spl/spl-kmem.c : Make sure to disable interruptswartens22008-04-162-14/+29
| | | | | | | | | | when necessary to avoid deadlocks. We were seeing the deadlock when calling kmem_cache_generic_constructor() and then an interrupt forced us to end up calling kmem_cache_generic_destructor() which caused our deadlock. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@74 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* - Add some spinlocks to cover all the private data in the mutex. I don'tbehlendo2008-04-153-31/+76
| | | | | | | | | | | | | think this should fix anything but it's a good idea regardless. - Drop the lock before calling the construct/destructor for the slab otherwise we can't sleep in a constructor/destructor and for long running functions we may NMI. - Do something braindead, but safe for the console debug logs for now. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@73 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Just cleanup up an error case to avoid overspamming the console.behlendo2008-04-141-4/+2
| | | | | | | We get the stack once from the BUG() no reason to dump it twice. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@72 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Add hw_serial support based on a usermodehelper which runsbehlendo2008-04-121-17/+116
| | | | | | | | | | | at spl module load time can calls hostid. The resolved hostid is then fed back in to a proc entry for latter use. It's not a pretty thing, but it will work for now. The hw_serial is required for things such as 'zpool status' to work. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@71 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Adjust the condition variables to simply sleep uninteruptibly.behlendo2008-04-111-69/+32
| | | | | | | | | This way we don't have to contend with superious wakeups which it appears ZFS is not so careful to handle anyway. So this is probably for the best. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@70 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* - Add more strict in_atomic() checking to the mutex entrybehlendo2008-04-113-72/+122
| | | | | | | | | | | | | | | function just to be extra safety and paranoid. - Rewrite the thread shim to take full advantage of the new kernel kthread API. This greatly simplifies things. - Add a new regression test for thread_exit() to ensure it properly terminates a thread immediately without allowing futher execution of the thread. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@69 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Fix race in rwlock implementation which can occur whenbehlendo2008-04-072-2/+11
| | | | | | | | | your task is rescheduled to a different cpu after you've taken the lock but before calling RW_LOCK_HELD is called. We need the spinlock to ensure there is a wmb() there. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@68 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* - Fix write-only behavior in vn-open()behlendo2008-04-043-23/+23
| | | | | | | | | | | - Ensure we have at least 1 write-only splat test - Fix return codes for vn_* Solaris does not use negative return codes in the kernel. So linux errno's must be inverted. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@67 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Update the thread shim to use the current kernel threading API.behlendo2008-04-042-17/+17
| | | | | | | | | | | | | | We need to use kthread_create() here for a few reasons. First off to old kernel_thread() API functioin will be going away. Secondly, and more importantly if I use kthread_create() we can then properly implement a thread_exit() function which terminates the kernel thread at any point with do_exit(). This fixes our cleanup bug which was caused by dropping a mutex twice after thread_exit() didn't really exit. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@66 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Correctly implement atomic_cas_ptr() function. Ideally all of thesebehlendo2008-04-032-14/+10
| | | | | | | | atomic operations will be rewritten anyway with the correct arch specific assembly. But not today. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@65 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* - Remapped ldi_handle_t to struct block_device * which is much more usefulbehlendo2008-04-034-11/+23
| | | | | | | | | | | | | - Added liunx block device headers to sunldi.h - Made __taskq_dispatch safe for interrupt context where it turns out we need to be useing it. - Fixed NULL const/dest bug for kmem slab caches - Places debug __dprintf debugging messages under a spin_lock_irqsave so it's safe to use then in interrupt handlers. For debugging only! git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@64 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Apparently it's OK for done to be NULL, which was not clear in thebehlendo2008-04-011-1/+5
| | | | | | | | Solaris man page. Anyway, since apparently this usage is accectable I've updated the function to handle it. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@63 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Double large kmalloc warning size to 4 pages. It was 2 pages, and ideallybehlendo2008-04-012-1/+65
| | | | | | | | | | | | | it should be dropped to one page but in the short term we should be able to easily live with 4 page allocations. Fix the nvlist bug, it turns out the user space side of things were packing the nvlists correctly as little endian, and the kernel space side of things due to a missing #define were unpacking them as big endian. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@62 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Ensure all file ops pointer are NULL or we may end upbehlendo2008-04-011-1/+1
| | | | | | | | | calling garbage pointers on open/close etc and get what look like random crashes. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@61 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Add vmem_zalloc support.behlendo2008-03-311-11/+18
| | | | git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@60 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Add some crude debugging support. It leaves alot to bebehlendo2008-03-319-38/+248
| | | | | | | desired, but it should allow more easy kernel debugging for now. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@59 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Fixed that.behlendo2008-03-281-2/+0
| | | | git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@58 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Correctly functioning 64-bit atomic shim layer. It's notbehlendo2008-03-287-11/+272
| | | | | | | | | | what I would call effecient but it does have the advantage of being correct which is all I need right now. I added a regression test as well. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@57 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* Remove minor lingering CDDL tait of copied headers. Requiredbehlendo2008-03-278-1661/+93
| | | | | | | | headers rewritten to include minimally what we need. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@56 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
* - Thinko fix to the SPL module interfacebehlendo2008-03-272-12/+15
| | | | | | | | | | - Enhanse the VERIFY() support to output the values which failed to compare as expected before crashing. This make debugging much much much easier. git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@55 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-29 13:52:22 +0000