aboutsummaryrefslogtreecommitdiffstats
path: root/.github
Commit message (Collapse)AuthorAgeFilesLines
* Add an .editorconfig; document git whitespace settingsGraham Christensen2020-01-271-3/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Most of the projects I work on don't use tabs, and while authoring my first patch I had to wrestle with my editor to not introduce whitespace editors. The `.editorconfig` file is supported by a large number of editors out of the box, and many more with plugins. As a first-time contributor, I can't say for certain these settings are totally correct, but thus far git and my editor are satisfied enough. I considered adding `git config --local format.signOff true` but wanted to respect the warning: format.signOff A boolean value which lets you enable the -s/--signoff option of format-patch by default. Note: Adding the Signed-off-by: line to a patch should be a conscious act and means that you certify you have the rights to submit this work under the same open source license. Please see the SubmittingPatches document for further discussion. Reviewed-by: George Melikov <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Graham Christensen <[email protected]> Closes #9892
* Improve Pull Request guidelinesKjeld Schouten-Lebbing2019-12-302-2/+29
| | | | | | | | | | | | | | | | - Splits PR advice into two sections. - Add "co-authored-by" instructions. - Add description of draft PR and when using it is appropriate. - Reword ZFS Test Suite checklist question. - Link to zfs-tests.sh and zloop.sh. Reviewed-By: Marcel Schilling <[email protected]> Reviewed-By: Brian Behlendorf <[email protected]> Reviewed-By: Richard Laager <[email protected]> Co-Authored-By: Marcel Schilling <[email protected]> Co-Authored-By: Brian Behlendorf <[email protected]> Co-Authored-By: Richard Laager <[email protected]> Signed-off-by: Kjeld Schouten-Lebbing <[email protected]> Closes #9753
* Moves Codecov Ignore to LCOVKjeld Schouten-Lebbing2019-12-171-2/+1
| | | | | | | | | | | | | Rely on ax_code_coverage to exclude test directories. - Removes broken codecov ignore - Places ignore section in ax_code_coverage - Forwards users from codecov to LCOV for ignores Reviewed-by: Prakash Surya <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Richard Laager <[email protected]> Signed-off-by: Kjeld Schouten-Lebbing <[email protected]> Closes #9726
* Fixes typo from #9681Kjeld Schouten2019-12-091-1/+1
| | | | | | | | | | | | | | Going from #9672 to 9681 I made a typo. This removes that typo. The pattern folder /* will not match recursively in the folder. Please use this folder /**/* source: https://docs.codecov.io/docs/ignoring-paths Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Reviewed-by: Richard Laager <[email protected]> Signed-off-by: Kjeld Schouten-Lebbing <[email protected]> Closes #9700
* Fix codecov ignore, wrong syntaxKjeld Schouten2019-12-061-1/+1
| | | | | | | | | The current codecov ignore syntax is incorrect. Corrected it. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: Kjeld Schouten-Lebbing <[email protected]> Closes #9681
* Codecov tweaksKjeld Schouten2019-12-031-1/+5
| | | | | | | | | | | | | | Modify the Codecov settings to provide a more realistic and stable report. The following change were made: - Precision has been limited to whole percents only, but will round to nearest. This means 0.0-0.49 will round to zero (no change) and 0.51 will round to 1%. - Exclude the tests/zfs-tests directory from the report. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Kjeld Schouten-Lebbing <[email protected]> Closes #9650
* Fix typosAndrea Gelmini2019-09-021-1/+1
| | | | | | | Reviewed-by: Ryan Moeller <[email protected]> Reviewed-by: Richard Laager <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Andrea Gelmini <[email protected]> Closes #9251
* Update CONTRIBUTING to point users to IRC as well as mailing listkpande2019-03-131-4/+5
| | | | | | | Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Richard Laager <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Kash Pande <[email protected]> Closes #8466
* Bump commit subject length to 72 charactersNeal Gompa (ニール・ゴンパ)2019-01-081-1/+1
| | | | | | | | | | | | | There's not really a reason to keep the subject length so short, since the reason to make it this short was for making nice renders of a summary list of the git log. With 72 characters, this still works out fine, so let's just raise it to that so that it's easier to give slightly more descriptive change summaries. Reviewed by: Matt Ahrens <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Neal Gompa <[email protected]> Closes #8250
* Advise users to retain issue/PR templatesbunder20152018-10-172-1/+4
| | | | | | | | | | | | | | Occasionally we get issues and PRs from users who delete the templates. Advise users that their issues and PRs may be closed if they do not fill out the templates as we really need this information. Also updating PR template to drop unneeded approval toggle as we are now using issue labels for status tracking. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Reviewed-by: Matthew Ahrens <[email protected]> Signed-off-by: bunder2015 <[email protected]> Closes #8029
* Add new wiki page to CONTRIBUTINGbunder20152018-09-181-0/+1
| | | | | | | | | | | A new wiki page has been added for users who may be new to Git or GitHub. Adding link to CONTRIBUTING. Reviewed-by: Richard Elling <[email protected]> Reviewed-by: Gregor Kopka <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: bunder2015 <[email protected]> Closes #7923 Closes #7915
* PR's should provide motivation & context firstMatthew Ahrens2018-07-231-3/+3
| | | | | | | | | | | | | | It's often necessary to understand why a change is made, before understanding the exact changes that are made. Context provides background, which by definition is necessary to understand prior to the substance of the Pull Request. Change the PR template to request "Motivation and Context" first, before "Description". Reviewed-by: Giuseppe Di Natale <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Matthew Ahrens <[email protected]> Closes #7737
* Small cleanup of PR and issue templatesGeorge Melikov2018-05-152-13/+13
| | | | | | | | | | | | - Add links to PULL_REQUEST_TEMPLATE.md - Clean `System information` table It's easier to find needes documentation about PR process with links. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Giuseppe Di Natale <[email protected]> Signed-off-by: George Melikov <[email protected]> Closes #7539
* Reduce codecov PR commentsBrian Behlendorf2018-01-091-1/+2
| | | | | | | | | | | | Attempt to reduce the number of comments posted by codecov to PR requests. Based on the codecov documenation setting "require_changes=yes" and "behavior=once" should result in a single comment under most circumstances. https://docs.codecov.io/v4.3.6/docs/pull-request-comments Signed-off-by: Brian Behlendorf <[email protected]> Issue #7022 Closes #7025
* Update for cppcheck v1.80Brian Behlendorf2017-11-181-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve new warnings and errors from cppcheck v1.80. * [lib/libshare/libshare.c:543]: (warning) Possible null pointer dereference: protocol * [lib/libzfs/libzfs_dataset.c:2323]: (warning) Possible null pointer dereference: srctype * [lib/libzfs/libzfs_import.c:318]: (error) Uninitialized variable: link * [module/zfs/abd.c:353]: (error) Uninitialized variable: sg * [module/zfs/abd.c:353]: (error) Uninitialized variable: i * [module/zfs/abd.c:385]: (error) Uninitialized variable: sg * [module/zfs/abd.c:385]: (error) Uninitialized variable: i * [module/zfs/abd.c:553]: (error) Uninitialized variable: i * [module/zfs/abd.c:553]: (error) Uninitialized variable: sg * [module/zfs/abd.c:763]: (error) Uninitialized variable: i * [module/zfs/abd.c:763]: (error) Uninitialized variable: sg * [module/zfs/abd.c:305]: (error) Uninitialized variable: tmp_page * [module/zfs/zpl_xattr.c:342]: (warning) Possible null pointer dereference: value * [module/zfs/zvol.c:208]: (error) Uninitialized variable: p Convert the following suppression to inline. * [module/zfs/zfs_vnops.c:840]: (error) Possible null pointer dereference: aiov Exclude HAVE_UIO_ZEROCOPY and HAVE_DNLC from analysis since these macro's will never be defined until this functionality is implemented. Reviewed-by: George Melikov <[email protected]> Reviewed-by: Giuseppe Di Natale <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes #6879
* commitcheck: Multiple OpenZFS ports in commitGiuseppe Di Natale2017-10-261-11/+42
| | | | | | | | | | | | Allow commitcheck.sh to handle multiple OpenZFS ports in a single commit. This is useful in the cases when a change upstream has bug fixes and it makes sense to port them with the original patch. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Reviewed-by: Chris Dunlop <[email protected]> Signed-off-by: Giuseppe Di Natale <[email protected]> Closes #6780
* Provide commit message format for Coverity defectsGiuseppe Di Natale2017-10-231-11/+45
| | | | | | | | | Provide details about the commit message format for Coverity defect fixes submitted. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Giuseppe Di Natale <[email protected]> Closes #6771
* Update codecov.io behaviorBrian Behlendorf2017-10-181-17/+8
| | | | | | | | | | | | | | | | | | | | | | | Update the codecov.yml included in the repository to behave as originally intended. This can be refined as needed. * Always post coverage results to the GitHub PR after two builds have been uploaded. This is the normal case since there will be a build uploaded for both kernel and user coverage results. * Adjust red -> yellow -> green coloring in the web interface. Due to the number of unlikely error conditions which are hard to force consider 90% coverage an excellent level of coverage. * Allow a 1% variance in coverage between test runs. This is approximately 10x larger than the typical variance observed which leaves us a reasonable margin to prevent false positives. * Always post a new smaller comment to PRs which does not include a file list. Old coverage reports are removed. Reviewed by: Prakash Surya <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes #6765
* Update codecov.ymlBrian Behlendorf2017-09-221-5/+26
| | | | | | | | | | | | | | | Update the codecov.yml to make the following functional changes. * Do not require the CI testing to pass before posting results. * Set red-yellow-green coverage percent from 50%-100% * Allow a 1% drop in coverage to still be considered a pass. * Reduce the size of the comment posted to the issue. Additionally, the top level README.markdown has been updated to include the codecov.io badge and the project summary reworded. Reviewed-by: Prakash Surya <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes #6669
* Correct cppcheck errorsGiuseppe Di Natale2017-09-191-0/+4
| | | | | | | | | | | | | ZFS buildbot STYLE builder was moved to Ubuntu 17.04 which has a newer version of cppcheck. Handle the new cppcheck errors. uu_* functions removed in this commit were unused and effectively dead code. They are now retired. Reviewed-by: George Melikov <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Giuseppe Di Natale <[email protected]> Closes #6653
* Add configure option to enable gcov analysisBrian Behlendorf2017-09-151-0/+9
| | | | | | | | | * Add configure option to enable gcov analysis. * Includes a few minor ctime fixes. * Add codecov.yml configuration. Reviewed-by: Prakash Surya <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes #6642
* Provide links to info about ZFS Buildbot optionsGiuseppe Di Natale2017-06-152-0/+8
| | | | | | | | Add links for information about the ZFS buildbot options to the contributing guidelines and PR template. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Giuseppe Di Natale <[email protected]> Closes #6235
* Explain reason for Signed-off-by in CONTRIBUTINGkpande2017-05-311-2/+6
| | | | | | | | Reviewed-by: Giuseppe Di Natale <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Reviewed-by: Haakan T Johansson <[email protected]> Signed-off-by: Kash Pande <[email protected]> Closes #6183
* Commit message format in contributing guidelinesGiuseppe Di Natale2017-03-312-0/+68
| | | | | | | | | | Add the need to have a commit message with a specific format to the contributing guidelines. Provide a script to help enforce commit message style. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Giuseppe Di Natale <[email protected]> Closes #5943
* Further work on Github usability (issue templates)George Melikov2017-01-031-3/+12
| | | | | | | | Make issue template more obvious about importance of searching the issue tracker first, and wrap logs appropriately. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Giuseppe Di Natale <[email protected]> Closes #5542
* Add CONTRIBUTING information and templatesGeorge Melikov2016-12-093-0/+221
Guidelines for developers and users describing how they can participle in the project. Reviewed-by: Manuel Mendez <[email protected]> Reviewed-by: Giuseppe Di Natale <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: George Melikov <[email protected]> Closes #672 Closes #4776 Closes #5361
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-23 12:30:25 +0000