summaryrefslogtreecommitdiffstats
path: root/tests/zfs-tests
diff options
context:
space:
mode:
Diffstat (limited to 'tests/zfs-tests')
-rw-r--r--tests/zfs-tests/cmd/file_write/file_write.c5
-rw-r--r--tests/zfs-tests/cmd/randfree_file/randfree_file.c9
2 files changed, 10 insertions, 4 deletions
diff --git a/tests/zfs-tests/cmd/file_write/file_write.c b/tests/zfs-tests/cmd/file_write/file_write.c
index 43fd96ac4..046794820 100644
--- a/tests/zfs-tests/cmd/file_write/file_write.c
+++ b/tests/zfs-tests/cmd/file_write/file_write.c
@@ -127,7 +127,10 @@ main(int argc, char **argv)
err++;
}
- if (err) usage(prog);
+ if (err) {
+ usage(prog); /* no return */
+ return (1);
+ }
/*
* Prepare the buffer and determine the requested operation
diff --git a/tests/zfs-tests/cmd/randfree_file/randfree_file.c b/tests/zfs-tests/cmd/randfree_file/randfree_file.c
index 8e7487c41..ff30c24c0 100644
--- a/tests/zfs-tests/cmd/randfree_file/randfree_file.c
+++ b/tests/zfs-tests/cmd/randfree_file/randfree_file.c
@@ -83,23 +83,26 @@ main(int argc, char *argv[])
else
usage(argv[0]);
- buf = (char *)malloc(filesize);
-
if ((fd = open(filename, O_RDWR | O_CREAT | O_TRUNC, mode)) < 0) {
perror("open");
return (1);
}
+
+ buf = (char *)malloc(filesize);
+
if (write(fd, buf, filesize) < filesize) {
+ free(buf);
perror("write");
return (1);
}
+ free(buf);
+
if (fallocate(fd, FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE,
start_off, off_len) < 0) {
perror("fallocate");
return (1);
}
- free(buf);
return (0);
}