diff options
author | Brian Behlendorf <[email protected]> | 2012-10-31 10:06:34 -0700 |
---|---|---|
committer | Brian Behlendorf <[email protected]> | 2012-11-09 19:01:09 -0800 |
commit | 4c837f0d931546e656b832caf11b8d4c2063d905 (patch) | |
tree | a5a19bfb82f907861f24bf2946e42917509a2a21 /udev | |
parent | e26ade5101ba1d8e8350ff1270bfca4258e1ffe3 (diff) |
Fix "allocating allocated segment" panic
Gunnar Beutner did all the hard work on this one by correctly
identifying that this issue is a race between dmu_sync() and
dbuf_dirty().
Now in all cases the caller is responsible for preventing this
race by making sure the zfs_range_lock() is held when dirtying
a buffer which may be referenced in a log record. The mmap
case which relies on zfs_putpage() was not taking the range
lock. This code was accidentally dropped when the function
was rewritten for the Linux VFS.
This patch adds the required range locking to zfs_putpage().
It also adds the missing ZFS_ENTER()/ZFS_EXIT() macros which
aren't strictly required due to the VFS holding a reference.
However, this makes the code more consistent with the upsteam
code and there's no harm in being extra careful here.
Original-patch-by: Gunnar Beutner <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #541
Diffstat (limited to 'udev')
0 files changed, 0 insertions, 0 deletions