diff options
| author | Brian Behlendorf <[email protected]> | 2018-01-17 10:17:16 -0800 |
|---|---|---|
| committer | GitHub <[email protected]> | 2018-01-17 10:17:16 -0800 |
| commit | 3da3488e6339ff2dc5c7f3da8c8a0c552d018d68 (patch) | |
| tree | acf9843a79221a7fa9de852507d3cdef8772ee44 /tests | |
| parent | d658b2caa95726c13d99123874910cdedc7ce866 (diff) | |
Fix shellcheck v0.4.6 warnings
Resolve new warnings reported after upgrading to shellcheck
version 0.4.6. This patch contains no functional changes.
* egrep is non-standard and deprecated. Use grep -E instead. [SC2196]
* Check exit code directly with e.g. 'if mycmd;', not indirectly
with $?. [SC2181] Suppressed.
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Giuseppe Di Natale <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #7040
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/zfs-tests/tests/functional/acl/acl_common.kshlib | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/zfs-tests/tests/functional/acl/acl_common.kshlib b/tests/zfs-tests/tests/functional/acl/acl_common.kshlib index def25d390..75bb82455 100644 --- a/tests/zfs-tests/tests/functional/acl/acl_common.kshlib +++ b/tests/zfs-tests/tests/functional/acl/acl_common.kshlib @@ -410,7 +410,7 @@ function get_xattr #<obj> fi for xattr in `runat $obj ls | \ - /usr/xpg4/bin/egrep -v -e SUNWattr_ro -e SUNWattr_rw` ; do + grep -E -v -e SUNWattr_ro -e SUNWattr_rw` ; do runat $obj sum $xattr done } |