diff options
author | Sara Hartse <[email protected]> | 2019-04-04 18:57:06 -0700 |
---|---|---|
committer | Brian Behlendorf <[email protected]> | 2019-04-04 18:57:06 -0700 |
commit | a887d653b32aaba3fe04c7b25ff0091b9ea9c64e (patch) | |
tree | 6d0bd45a6d2080fce9223ae252f5c93782418dd7 /tests | |
parent | af6507930051e9ee481cad1130df84636c4a770c (diff) |
Restrict kstats and print real pointers
There are several places where we use zfs_dbgmsg and %p to
print pointers. In the Linux kernel, these values obfuscated
to prevent information leaks which means the pointers aren't
very useful for debugging crash dumps. We decided to restrict
the permissions of dbgmsg (and some other kstats while we were
at it) and print pointers with %px in zfs_dbgmsg as well as
spl_dumpstack
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: John Gallagher <[email protected]>
Signed-off-by: sara hartse <[email protected]>
Closes #8467
Closes #8476
Diffstat (limited to 'tests')
-rwxr-xr-x | tests/zfs-tests/tests/functional/cli_user/misc/dbufstat_001_pos.ksh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/zfs-tests/tests/functional/cli_user/misc/dbufstat_001_pos.ksh b/tests/zfs-tests/tests/functional/cli_user/misc/dbufstat_001_pos.ksh index 95f0598c6..0e187015f 100755 --- a/tests/zfs-tests/tests/functional/cli_user/misc/dbufstat_001_pos.ksh +++ b/tests/zfs-tests/tests/functional/cli_user/misc/dbufstat_001_pos.ksh @@ -33,11 +33,11 @@ log_assert "dbufstat generates output and doesn't return an error code" typeset -i i=0 while [[ $i -lt ${#args[*]} ]]; do - log_must eval "dbufstat ${args[i]} > /dev/null" + log_must eval "sudo dbufstat ${args[i]} > /dev/null" ((i = i + 1)) done # A simple test of dbufstat filter functionality -log_must eval "dbufstat -F object=10,dbc=1,pool=$TESTPOOL > /dev/null" +log_must eval "sudo dbufstat -F object=10,dbc=1,pool=$TESTPOOL > /dev/null" log_pass "dbufstat generates output and doesn't return an error code" |