diff options
author | Damian Szuberski <[email protected]> | 2022-02-03 23:35:38 +0100 |
---|---|---|
committer | GitHub <[email protected]> | 2022-02-03 14:35:38 -0800 |
commit | 63652e154643cfe596fe077c13de0e7be34dd863 (patch) | |
tree | a357fcff504f2b8fbdce59b236788435556b45f8 /tests/zfs-tests/include | |
parent | aa9905d89b3559e1cd280d018615d392f57a18d0 (diff) |
Add `--enable-asan` and `--enable-ubsan` switches
`configure` now accepts `--enable-asan` and `--enable-ubsan` switches
which results in passing `-fsanitize=address`
and `-fsanitize=undefined`, respectively, to the compiler. Those
flags are enabled in GitHub workflows for ZTS and zloop. Errors
reported by both instrumentations are corrected, except for:
- Memory leak reporting is (temporarily) suppressed. The cost of
fixing them is relatively high compared to the gains.
- Checksum computing functions in `module/zcommon/zfs_fletcher*`
have UBSan errors suppressed. It is completely impractical
to enforce 64-byte payload alignment there due to performance
impact.
- There's no ASan heap poisoning in `module/zstd/lib/zstd.c`. A custom
memory allocator is used there rendering that measure
unfeasible.
- Memory leaks detection has to be suppressed for `cmd/zvol_id`.
`zvol_id` is run by udev with the help of `ptrace(2)`. Tracing is
incompatible with memory leaks detection.
Reviewed-by: Ahelenia ZiemiaĆska <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes #12928
Diffstat (limited to 'tests/zfs-tests/include')
-rw-r--r-- | tests/zfs-tests/include/commands.cfg | 1 | ||||
-rw-r--r-- | tests/zfs-tests/include/default.cfg.in | 15 |
2 files changed, 16 insertions, 0 deletions
diff --git a/tests/zfs-tests/include/commands.cfg b/tests/zfs-tests/include/commands.cfg index 13fee6752..51052e801 100644 --- a/tests/zfs-tests/include/commands.cfg +++ b/tests/zfs-tests/include/commands.cfg @@ -51,6 +51,7 @@ export SYSTEM_FILES_COMMON='arp iostat kill ksh + ldd ln logname ls diff --git a/tests/zfs-tests/include/default.cfg.in b/tests/zfs-tests/include/default.cfg.in index 1a9cc5a2b..cf382cfe9 100644 --- a/tests/zfs-tests/include/default.cfg.in +++ b/tests/zfs-tests/include/default.cfg.in @@ -155,6 +155,21 @@ done export MAX_PARTITIONS=8 +if [ "@ASAN_ENABLED@" = "yes" ]; then + export ASAN_OPTIONS=abort_on_error=true:halt_on_error=true:allocator_may_return_null=true:disable_coredump=false:detect_stack_use_after_return=true + + # TODO + # disable memory leaks detection + # there are quite many of them and they are not as + # destructive to CLI programs as they are to daemons + export ASAN_OPTIONS="$ASAN_OPTIONS:detect_leaks=false" +fi + +if [ "@UBSAN_ENABLED@" = "yes" ]; then + export UBSAN_OPTIONS=abort_on_error=true:halt_on_error=true:print_stacktrace=true +fi + + case $(uname -o) in GNU/Linux) unpack_opts="--sparse -xf" |