diff options
| author | Christian Schwarz <[email protected]> | 2019-11-10 23:24:14 -0800 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2020-02-11 13:19:12 -0800 |
| commit | a73f361fdb2c0a7778e70b482e316054fc2d8630 (patch) | |
| tree | 094642f07952d4149c2dab358a35910961d0c42e /tests/runfiles | |
| parent | 7b49bbc8164a8a5cd31cf1ba7a6cd88269fec8d0 (diff) | |
Implement bookmark copying
This feature allows copying existing bookmarks using
zfs bookmark fs#target fs#newbookmark
There are some niche use cases for such functionality,
e.g. when using bookmarks as markers for replication progress.
Copying redaction bookmarks produces a normal bookmark that
cannot be used for redacted send (we are not duplicating
the redaction object).
ZCP support for bookmarking (both creation and copying) will be
implemented in a separate patch based on this work.
Overview:
- Terminology:
- source = existing snapshot or bookmark
- new/bmark = new bookmark
- Implement bookmark copying in `dsl_bookmark.c`
- create new bookmark node
- copy source's `zbn_phys` to new's `zbn_phys`
- zero-out redaction object id in copy
- Extend existing bookmark ioctl nvlist schema to accept
bookmarks as sources
- => `dsl_bookmark_create_nvl_validate` is authoritative
- use `dsl_dataset_is_before` check for both snapshot
and bookmark sources
- Adjust CLI
- refactor shortname expansion logic in `zfs_do_bookmark`
- Update man pages
- warn about redaction bookmark handling
- Add test cases
- CLI
- pyyzfs libzfs_core bindings
Reviewed-by: Matt Ahrens <[email protected]>
Reviewed-by: Paul Dagnelie <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Christian Schwarz <[email protected]>
Closes #9571
Diffstat (limited to 'tests/runfiles')
| -rw-r--r-- | tests/runfiles/common.run | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/tests/runfiles/common.run b/tests/runfiles/common.run index 81cca7eed..691cae9cb 100644 --- a/tests/runfiles/common.run +++ b/tests/runfiles/common.run @@ -86,7 +86,10 @@ tests = ['tst.destroy_fs', 'tst.destroy_snap', 'tst.get_count_and_limit', 'tst.list_user_props', 'tst.parse_args_neg','tst.promote_conflict', 'tst.promote_multiple', 'tst.promote_simple', 'tst.rollback_mult', 'tst.rollback_one', 'tst.snapshot_destroy', 'tst.snapshot_neg', - 'tst.snapshot_recursive', 'tst.snapshot_simple', 'tst.terminate_by_signal'] + 'tst.snapshot_recursive', 'tst.snapshot_simple', + 'tst.bookmark.create', 'tst.bookmark.clone', + 'tst.terminate_by_signal' + ] tags = ['functional', 'channel_program', 'synctask_core'] [tests/functional/checksum] |