diff options
| author | Brian Behlendorf <[email protected]> | 2021-06-09 12:21:24 -0700 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2021-06-10 10:50:16 -0700 |
| commit | 1180d61152ff71f0d6d1406bf24b6108b4759e52 (patch) | |
| tree | b4561d010dfd4109dfd6b17714e35120fe40f409 /scripts | |
| parent | 6ce97bb4a288cd0fa14b4f9690ebc70575a93d02 (diff) | |
Fix minor shellcheck 0.7.2 warnings
The first warning of a misspelling is a false positive, so we annotate
the script accordingly. As for the x-prefix warnings update the check
to use the conventional '[ -z <string> ]' syntax.
all-syslog.sh:46:47: warning: Possible misspelling: ZEVENT_ZIO_OBJECT
may not be assigned, but ZEVENT_ZIO_OBJSET is. [SC2153]
make_gitrev.sh:53:6: note: Avoid x-prefix in comparisons as it no
longer serves a purpose [SC2268]
man-dates.sh:10:7: note: Avoid x-prefix in comparisons as it no
longer serves a purpose [SC2268]
Reviewed-by: Ahelenia Ziemiańska <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #12208
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/make_gitrev.sh | 2 | ||||
| -rwxr-xr-x | scripts/man-dates.sh | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/scripts/make_gitrev.sh b/scripts/make_gitrev.sh index da2145533..e7f4ce884 100755 --- a/scripts/make_gitrev.sh +++ b/scripts/make_gitrev.sh @@ -50,7 +50,7 @@ esac ZFS_GITREV=$({ cd "${top_srcdir}" && git describe --always --long --dirty 2>/dev/null; } || :) -if [ "x${ZFS_GITREV}" = x ] +if [ -z "${ZFS_GITREV}" ] then # If the source directory is not a git repository, check if the file # already exists (in the source) diff --git a/scripts/man-dates.sh b/scripts/man-dates.sh index 186d94639..39f1b5fb1 100755 --- a/scripts/man-dates.sh +++ b/scripts/man-dates.sh @@ -7,6 +7,6 @@ set -eu find man -type f | while read -r i ; do git_date=$(git log -1 --date=short --format="%ad" -- "$i") - [ "x$git_date" = "x" ] && continue + [ -z "$git_date" ] && continue sed -i "s|^\.Dd.*|.Dd $(date -d "$git_date" "+%B %-d, %Y")|" "$i" done |